New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hc dna pack inconsistencies #1479
Conversation
Merge release-20220706.013407 back into develop
awesome! |
Functionally this looks fine but the diff is a bit messed up. Maybe pull in develop and I can approve. |
@freesig Thanks, develop pulled in |
AD4M is currently blocked with regards to updating to a recent Holochain version because of this. Templating AD4M Languages and the Holochain DNAs in them is quite a core aspect and used to verify Language source code when an agent installs a new Language. Having Wondering what's holding up this one-line fix and just took a look at the failing CI workflow. Could it be failing just because the PR is coming in from an external repo? |
Yes, that must be it. This is a PR with the same changes but from an internal branch, and it passes all CI workflows: #1492 |
Summary
Fixes #1475 by storing bundle resources as a
BTreeMap
vsMap
. Before when writing out the bundle the resources were written in an inconsistent order, causing the hash of result.dna
files to differ.TODO: