Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hc dna pack inconsistencies #1479

Merged
merged 7 commits into from Jul 18, 2022
Merged

Fix hc dna pack inconsistencies #1479

merged 7 commits into from Jul 18, 2022

Conversation

jdeepee
Copy link
Contributor

@jdeepee jdeepee commented Jul 8, 2022

Summary

Fixes #1475 by storing bundle resources as a BTreeMap vs Map. Before when writing out the bundle the resources were written in an inconsistent order, causing the hash of result .dna files to differ.

TODO:

  • CHANGELOG(s) updated with appropriate info
  • Just before pressing the merge button, ensure new entries to CHANGELOG(s) are still under the UNRELEASED heading

@pegaltier
Copy link

awesome!

@freesig
Copy link
Contributor

freesig commented Jul 13, 2022

Functionally this looks fine but the diff is a bit messed up. Maybe pull in develop and I can approve.

@jdeepee
Copy link
Contributor Author

jdeepee commented Jul 13, 2022

@freesig Thanks, develop pulled in

@freesig freesig self-requested a review July 13, 2022 12:27
@lucksus
Copy link
Collaborator

lucksus commented Jul 18, 2022

AD4M is currently blocked with regards to updating to a recent Holochain version because of this. Templating AD4M Languages and the Holochain DNAs in them is quite a core aspect and used to verify Language source code when an agent installs a new Language. Having hc dna pack create different hashes in-deterministically breaks our templating checks.

Wondering what's holding up this one-line fix and just took a look at the failing CI workflow. Could it be failing just because the PR is coming in from an external repo?

@lucksus
Copy link
Collaborator

lucksus commented Jul 18, 2022

Yes, that must be it. This is a PR with the same changes but from an internal branch, and it passes all CI workflows: #1492

@freesig freesig merged commit dd9e599 into holochain:develop Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] hc pack sometimes creates different .dna files
5 participants