refactor(uid): rename uid to network_seed #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jost-s
force-pushed
the
refactor/rename-uid-to-network-seed
branch
from
0c291f3
to
3bcb617
Compare
jost-s
force-pushed
the
refactor/rename-uid-to-network-seed
branch
from
3bcb617
to
2419332
Compare
jost-s
force-pushed
the
refactor/rename-uid-to-network-seed
branch
from
2419332
to
8e96730
Compare
jost-s
force-pushed
the
refactor/rename-uid-to-network-seed
branch
from
8c303ec
to
c31875b
Compare
… refactor/rename-uid-to-network-seed
maackle
approved these changes
Jul 20, 2022
| /// The DNA hash in turn determines the network peers and the DHT, meaning | ||
| /// that only peers with the same DNA hash of a shared DNA participate in the | ||
| /// same network and co-create the DHT. To create a separate DHT for the DNA, | ||
| /// a unique network seed can be specified. | ||
| // TODO: consider Vec<u8> instead (https://github.com/holochain/holochain/pull/86#discussion_r412689085) |
There was a problem hiding this comment.
Anyone think we can take this TODO out now?
| @@ -14,8 +14,8 @@ pub type IntegrityZomes = Vec<(ZomeName, zome::IntegrityZomeDef)>; | |||
| /// Ordered list of coordinator zomes in this DNA. | |||
| pub type CoordinatorZomes = Vec<(ZomeName, zome::CoordinatorZomeDef)>; | |||
|
|
|||
| /// Placeholder for a real UID type | |||
| pub type Uid = String; | |||
| /// Placeholder for a real network seed type. See [`DnaDef`]. | |||
There was a problem hiding this comment.
out of curiousity, can anyone say what a "real network seed" is or would be?
… refactor/rename-uid-to-network-seed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO: