Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update coordinators admin interface #1494

Merged
merged 9 commits into from Aug 1, 2022
Merged

Update coordinators admin interface #1494

merged 9 commits into from Aug 1, 2022

Conversation

freesig
Copy link
Contributor

@freesig freesig commented Jul 21, 2022 •
edited

Summary

Adds updating of coordinator zomes to the admin interface.

TODO:

  • CHANGELOG(s) updated with appropriate info
  • Just before pressing the merge button, ensure new entries to CHANGELOG(s) are still under the UNRELEASED heading

@freesig freesig requested a review from maackle July 21, 2022 04:09
maackle
maackle requested changes Jul 22, 2022
View reviewed changes
Copy link
Member

@maackle maackle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes, but otherwise seems fine.

I'm also wondering if there is an immediate use case for this, and if so, if there is any feedback from devs who would use this? Is this mainly for debugging?

crates/holochain/tests/integrity_zome/mod.rs Outdated Show resolved Hide resolved
crates/holochain_types/src/dna/coordinator_bundle.rs Outdated Show resolved Hide resolved
@marycamacho
Copy link

Yikes ... anything named HOT swap in Holochain is misleading... many people looking at our open repo might assume the Holo HOT token swap when I'm sure that's not what was intended!

@freesig
Copy link
Contributor Author

freesig commented Jul 25, 2022

Yikes ... anything named HOT swap in Holochain is misleading... many people looking at our open repo might assume the Holo HOT token swap when I'm sure that's not what was intended!

Ahh good point. I didn't think of that. I was just using the term like this. I'll try and think of a better name.

@freesig freesig requested a review from maackle July 29, 2022 06:46
@freesig freesig changed the title Hot swap admin interface Update coordinators admin interface Jul 29, 2022
abe-njama
abe-njama reviewed Jul 29, 2022
View reviewed changes
crates/holochain_types/src/dna/dna_file.rs Outdated
@@ -87,11 +87,23 @@ impl DnaFile {
}

/// Hot swap coordinator zomes for this dna.
Copy link
Collaborator

@abe-njama abe-njama Jul 29, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still have code comments referencing Hot swap. Might want to change these to Update Coordinators as well. I saw some tests as well that have the term Hot swap in there. Looks something like

@@ async fn test_hotswap() {

maackle
maackle approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@maackle maackle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

crates/holochain_types/src/dna/dna_file/test.rs Outdated
@@ -198,3 +198,92 @@ async fn test_hotswap() {

assert_eq!(expect, dna);
}

#[tokio::test(flavor = "multi_thread")]
async fn test_hot_swap_checks_deps() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
async fn test_hot_swap_checks_deps() {
async fn test_update_coordinators_checks_deps() {

@freesig freesig enabled auto-merge August 1, 2022 01:05
@freesig freesig merged commit 9b2b53d into develop Aug 1, 2022
@freesig freesig deleted the hot-swap-admin branch August 1, 2022 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abe-njama abe-njama abe-njama left review comments

@maackle maackle maackle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@freesig @marycamacho @maackle @abe-njama