feat(cloning): add calls to archive/restore/delete clones #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
September 7, 2022 14:01
… feat/clone-cell-deletion
… feat/clone-cell-deletion
… feat/clone-cell-deletion
… feat/clone-cell-deletion
added 11 commits
September 15, 2022 15:23
… feat/clone-cell-deletion
… feat/clone-cell-deletion
maackle
approved these changes
Sep 20, 2022
| .conductor | ||
| .restore_clone_cell(&app_id, &clone_cell_id) | ||
| .await?; | ||
| self.create_and_add_initialized_cells_for_running_apps(self.clone(), Some(&app_id)) |
There was a problem hiding this comment.
Ah I see you added the line I expected above, here. Yeah, I see why you did this, since it's weird to pass a ConductorHandle down into the Conductor. I think ideally the ConductorHandle shouldn't do anything that the Conductor can't do itself. However, the whole ConductorHandle/Conductor thing has become a mess that needs to be reworked so I'm ok with this.
There was a problem hiding this comment.
I completely agree
There was a problem hiding this comment.
@abe-njama Please add this as a refactoring item for the post-beta phase.
added 3 commits
September 21, 2022 09:26
… feat/clone-cell-deletion
… feat/clone-cell-deletion
jost-s
force-pushed
the
feat/clone-cell-deletion
branch
from
e170b98
to
92cb1fa
Compare
maackle
reviewed
Sep 23, 2022
Co-authored-by: Michael Dougherty <maackle.d@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
documentand clonesdocument.0,document.1etc.; this call deletes all clones that have been archived permanently; not undoable, clones cannot be restored)phenotypetomodifiers(mostlyDnaPhenotypetoDnaModifiers)DnaModifiersin serde for structsAppRoleDnaManifestandCreateCloneCellPayloadTODO: