Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROPOSAL] hc pack recursive #1628

Merged
merged 8 commits into from Oct 23, 2022
Merged

[PROPOSAL] hc pack recursive #1628

merged 8 commits into from Oct 23, 2022

Conversation

guillemcordoba
Copy link
Collaborator

This is just a proposal to get feedback. I would love it if this or some version of it could be included in the release going out Wednesday the 26th, because that would mean we can use it in the Berlin hackathon.

Summary

  • Adds pack_all as an option to hc web-app pack and hc app pack, which packs all the "children" DNAs and app manifests that have their location bundled. This makes the build toolchain for a happ's repository easier to handle.

TODO:

  • CHANGELOG(s) updated with appropriate info
  • Just before pressing the merge button, ensure new entries to CHANGELOG(s) are still under the UNRELEASED heading

Copy link
Member

@maackle maackle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I was hoping somebody would do this eventually.

I didn't compile and run it myself so I don't know all the nuances of how it will work in different situations, but since this is an opt-in flag that doesn't affect the default behavior, it is sure to be an improvement.

I just have a naming suggestion.

crates/hc_bundle/src/cli.rs Outdated Show resolved Hide resolved
crates/hc_bundle/src/cli.rs Outdated Show resolved Hide resolved
guillemcordoba and others added 3 commits October 19, 2022 12:05
Co-authored-by: Michael Dougherty <maackle.d@gmail.com>
Co-authored-by: Michael Dougherty <maackle.d@gmail.com>
@guillemcordoba guillemcordoba marked this pull request as ready for review October 19, 2022 10:05
@guillemcordoba guillemcordoba changed the title [PROPOSAL] hc pack pack_all [PROPOSAL] hc pack recursive Oct 19, 2022
@guillemcordoba guillemcordoba merged commit bea5e52 into develop Oct 23, 2022
@guillemcordoba guillemcordoba deleted the hc-pack-all branch October 23, 2022 23:47
@maackle
Copy link
Member

maackle commented Oct 26, 2022

@guillemcordoba It might be nice to do some more planning on this. I'm not sure when. But I just tried to use the new feature and have some thoughts:

It seems to me that unpacking and then re-packing what was just unpacked should bring you right back to where you started, i.e. unpack and pack should be perfect inverses even when composed together. I just tried doing 3 unpacks (followed by cd to get to the unpacked directory), and then tried a recursive pack on the webapp root, but that didn't work.

It seems like we should also have a recursive unpack which would produce the same structure that a recursive pack expects.

I'm not sure if this is a mismatch of packing or unpacking with my intuition, but it seems like they should be in line so that one is exactly the inverse of the other, with no other options set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants