New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PROPOSAL] hc pack
recursive
#1628
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! I was hoping somebody would do this eventually.
I didn't compile and run it myself so I don't know all the nuances of how it will work in different situations, but since this is an opt-in flag that doesn't affect the default behavior, it is sure to be an improvement.
I just have a naming suggestion.
Co-authored-by: Michael Dougherty <maackle.d@gmail.com>
Co-authored-by: Michael Dougherty <maackle.d@gmail.com>
hc pack
pack_all hc pack
recursive
@guillemcordoba It might be nice to do some more planning on this. I'm not sure when. But I just tried to use the new feature and have some thoughts: It seems to me that unpacking and then re-packing what was just unpacked should bring you right back to where you started, i.e. unpack and pack should be perfect inverses even when composed together. I just tried doing 3 unpacks (followed by It seems like we should also have a recursive unpack which would produce the same structure that a recursive pack expects. I'm not sure if this is a mismatch of packing or unpacking with my intuition, but it seems like they should be in line so that one is exactly the inverse of the other, with no other options set. |
This is just a proposal to get feedback. I would love it if this or some version of it could be included in the release going out Wednesday the 26th, because that would mean we can use it in the Berlin hackathon.
Summary
pack_all
as an option tohc web-app pack
andhc app pack
, which packs all the "children" DNAs and app manifests that have their location bundled. This makes the build toolchain for a happ's repository easier to handle.TODO: