Add sizes to fetch queue #1694
Merged
Add sizes to fetch queue #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maackle
force-pushed
the
fetch-queue-sizes
branch
from
5a76900
to
20f3dde
Compare
maackle
commented
Dec 2, 2022
Comment on lines
+42
to
+50
| /// The space this op belongs to | ||
| pub space: KSpace, | ||
|
|
||
| /// The source to fetch the op from | ||
| pub source: FetchSource, | ||
|
|
||
| /// The approximate size of the item | ||
| pub size: Option<RoughInt>, | ||
|
|
There was a problem hiding this comment.
I just moved space and source into this struct (they were supplied independently before), but size is the new addition here to the push parameters.
neonphog
reviewed
Dec 5, 2022
| @@ -18,7 +18,7 @@ use holochain::{ | |||
| use holochain_p2p::*; | |||
| use holochain_sqlite::db::*; | |||
| use kitsune_p2p::agent_store::AgentInfoSigned; | |||
| use kitsune_p2p::gossip::sharded_gossip::test_utils::{check_ops_boom, create_agent_bloom}; | |||
| use kitsune_p2p::gossip::sharded_gossip::test_utils::{check_ops_bloom, create_agent_bloom}; | |||
neonphog
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds sizes to op hashes sent via historical gossip.
TODO: