Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call #453

Merged
merged 18 commits into from Nov 6, 2020
Merged

Call #453

merged 18 commits into from Nov 6, 2020

Conversation

freesig
Copy link
Contributor

@freesig freesig commented Oct 30, 2020

TODO:

  • Add to the change log
  • Figure out a to pass the workspace in when calling the same cell
  • Take a Option<DnaHash> to route calls to allow "bridge calls"
  • Docs
  • Test that calls another dna

@freesig freesig added please-one-approval merge base pr first The base of this pr needs to be merged first labels Oct 30, 2020

use crate::host_fn;

pub fn call(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice this is a function rather than a macro. Don't get me wrong -- the fewer exclamation points the better, esp for people who are using RLS for code intel -- but in order to be consistent with the other host functions, should it stay a macro for now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are planning to make them all function calls very soon

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather just change them all to functions then add in macros to then change back. It's not a big job to change them

Copy link
Contributor

@pdaoust pdaoust Nov 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That'd be lovely. Another thing that I've discovered in my "audit of RSM documentation" is that macros thwart rustdoc's ability to do auto-linking of argument and return types, which is painful for dev ergonomics. Means they have to do a lot of legwork themselves via the search box.

Copy link
Member

@maackle maackle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a bunch of kitsune stuff in here, how'd that happen?

crates/holochain/src/conductor/api/api_cell.rs Outdated Show resolved Hide resolved
Base automatically changed from d-01159 to develop November 1, 2020 22:29
@freesig
Copy link
Contributor Author

freesig commented Nov 1, 2020

There's a bunch of kitsune stuff in here, how'd that happen?

Maybe it was a dodgy diff? I can't see any kitsune stuff?

@freesig freesig removed the merge base pr first The base of this pr needs to be merged first label Nov 1, 2020
@freesig freesig merged commit e8b3efc into develop Nov 6, 2020
@freesig freesig deleted the call branch November 6, 2020 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants