New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call #453
Conversation
crates/hdk/src/host_fn/call.rs
Outdated
|
||
use crate::host_fn; | ||
|
||
pub fn call( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice this is a function rather than a macro. Don't get me wrong -- the fewer exclamation points the better, esp for people who are using RLS for code intel -- but in order to be consistent with the other host functions, should it stay a macro for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are planning to make them all function calls very soon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather just change them all to functions then add in macros to then change back. It's not a big job to change them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That'd be lovely. Another thing that I've discovered in my "audit of RSM documentation" is that macros thwart rustdoc's ability to do auto-linking of argument and return types, which is painful for dev ergonomics. Means they have to do a lot of legwork themselves via the search box.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a bunch of kitsune stuff in here, how'd that happen?
Maybe it was a dodgy diff? I can't see any kitsune stuff? |
TODO:
Option<DnaHash>
to route calls to allow "bridge calls"