Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: function that waits until all agents have identical dht state #167

Closed
mattyg opened this issue Mar 20, 2023 · 2 comments · Fixed by #171
Closed

Feature Request: function that waits until all agents have identical dht state #167

mattyg opened this issue Mar 20, 2023 · 2 comments · Fixed by #171
Labels
enhancement New feature or request

Comments

@mattyg
Copy link
Contributor

mattyg commented Mar 20, 2023

Currently when writing tryorama tests, we have to call sleep() after every zome call, waiting for changes to be gossiped to all agents. This makes for flaky tests that inconsistently fail if network conditions change, or slow tests that wait unecessesarily longer than needed because sleep time is static.

One way around this could be to introduce a function like waitForPeerSync(). This would compare the DHT state of all agents in the scenario and sleep until they are identical.

@jost-s
Copy link
Contributor

jost-s commented Mar 20, 2023

I believe I can implement a simple function that will take a list of agents to check for integration, which then periodically fetches a state dump and compares integrated op count.

@jost-s jost-s added the enhancement New feature or request label Mar 20, 2023
@jost-s
Copy link
Contributor

jost-s commented Mar 20, 2023

@abe-njama FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants