Fix auth issues #98

yusofy · 2023-06-13T12:59:56Z

This PR makes changes to a couple of Auth related things.

Changed the SignUp class in the auth model. name is no longer a list however still optional. Was changed as list was not an accepted format.
In the auth api, I raised an exception when a user is not found instead of a Traceback error being thrown.
In the auth api, I changed the status code for Invalid Credentials to be HTTP_401_UNAUTHORIZED instead of generic 400 error.

…as a list. Still is optional

…ead of throwing a Traceback error. Changed status code for Invalid credentials to HTTP_401_UNAUTHORIZED

homanp

@yusofy Big thanks for this update/fix.

Will be merged later today!

yusofy added 2 commits June 13, 2023 07:47

Removed name: Optional[str] in SignUp class model. It was showing up …

d8d833e

…as a list. Still is optional

Changed Auth API to raise HTTPException when user does not exist inst…

7208a64

…ead of throwing a Traceback error. Changed status code for Invalid credentials to HTTP_401_UNAUTHORIZED

homanp approved these changes Jun 13, 2023

View reviewed changes

homanp added 2 commits June 13, 2023 15:44

Fix formatting

e04e4f5

Remove unused import

c94106e

homanp merged commit a6d0a2e into superagent-ai:main Jun 13, 2023
4 checks passed

yusofy deleted the Fix_Auth_Issues branch June 13, 2023 15:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix auth issues #98

Fix auth issues #98

yusofy commented Jun 13, 2023

homanp left a comment

Fix auth issues #98

Fix auth issues #98

Conversation

yusofy commented Jun 13, 2023

homanp left a comment

Choose a reason for hiding this comment