-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Status- and Navigation bars are not being colored anymore on Core 2021.12.0b3 #1997
Comments
Can you check on b5 as that was released 4 hours ago? Also for beta issues like this we should communicate in #beta on discord |
Okay thank you, I fill remember that for the future :)
Yes I just updated and I can confirm, that this issue still remains |
So looks like HA core no longer sends https://developers.home-assistant.io/docs/api/websocket#fetching-config |
What I was just wondering about: Wouldn't it be a great Idea, if the websocket api of homeassistant had an endpoint to query the actual theme colors? like |
That's possible. This is how we fetch themes and subscribe to updates: https://github.com/home-assistant/frontend/blob/dev/src/data/ws-themes.ts#L30-L39 |
I actually thought about using the socket api again and Maybe its not ideal, because it would have the drawback of taking more time then just fetching the variables from the webview. I just played around with the new See: #2000 |
What would you think about adding the theme colors as payload to the "theme-update" event? @balloob? |
I decided to not include it, because we can't predict what data the mobile app will need in the future so better to let the mobile app gather it themselves. |
My thought is that because its only a message, that is only send through the external bus and not through the network or something, it should be fine to just send the whole theme (meaning all the official home assistant base colors.. not stuff like checkbox-color or something). That should not be too large to cause problems in my opinion 🤔 |
Home Assistant Android version: 2021.10.0-full
Android version: 11
Phone model: Xiaomi Mi 9T Pro
Home Assistant version: 2021.12.0b5
Last working Home Assistant release (if known): 2021.11.5
Description of problem:
I just updated to Home Assistant 2021.12.0b5 and realised, that the status and navigation bars are not getting colored anymore. This is especially visible in light mode, where they just stay black instead of getting colored blue.
I did some debugging and figured, that the android app is listening on a json object post with the type
config/get
which used to be send after the web app loaded. But it is not being send anymore. But when you open the Frontend Settings page, it is loaded, and the status and navigation bar are getting their colors.But of course this is not how it is supposed to be.
I also opened an Issue on the frontend repo, though I'm not really sure, where this post request comes from etc., so I'm not even sure if thats the right place and also nobody is answering issues on the frontend recently it seems like.
See: home-assistant/frontend/issues/10823
I figured that the android app team would be interested in this issue and might help reaching out to the people who are able to fix it :)
The text was updated successfully, but these errors were encountered: