Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last update sensor no longer showing settings on new installs #2673

Closed
dshokouhi opened this issue Jul 13, 2022 · 6 comments · Fixed by #2674
Closed

Last update sensor no longer showing settings on new installs #2673

dshokouhi opened this issue Jul 13, 2022 · 6 comments · Fixed by #2674
Labels
bug Something isn't working sensor-tracking settings

Comments

@dshokouhi
Copy link
Member

dshokouhi commented Jul 13, 2022

Home Assistant Android version:

latest master

Android version:
12
Phone model:
Pixel 6 pro
Home Assistant version:
2022.3.x
Last working Home Assistant release (if known):
Might be before #2585
Description of problem:

On a fresh install the last update sensor settings page is not showing the add new intent button so users can add intents. On an upgraded install with 1 intent registered it does work.

Traceback (if applicable, to get the logs you may refer to: https://companion.home-assistant.io/docs/troubleshooting/faqs/#android-crash-logs):


Screenshot of problem:

image

Additional information:

Reference: https://community.home-assistant.io/t/last-update-trigger-sensor/438968/

@dshokouhi dshokouhi added the bug Something isn't working label Jul 13, 2022
@dshokouhi
Copy link
Member Author

@marazmarci FYI in case this was introduced with #2585

@dshokouhi
Copy link
Member Author

Fix incoming, just need to add the toggle if we don't need to create a new intent.

@marazmarci
Copy link
Contributor

marazmarci commented Jul 13, 2022

Ohh, it must be introduced with my changes, very sorry! ☹️

@marazmarci
Copy link
Contributor

marazmarci commented Jul 13, 2022

And there's another bug that I discovered recently, but I didn't have time yet to report it:

When there are >10x Intents, the order will change every time there's a sensor update.
(It's caused by the alphabetical ordering of the numbers: "Intent 1" > "Intent 10")

And I think it can also cause data loss if the user is editing an Intent and there's an update happening in the background in the meantime (the list will be reordered), and the user hits save, so it will probably edit a different item in the list.

@dshokouhi
Copy link
Member Author

Oh wow I have not noticed that yet, I only use 2 intents personally haha

@marazmarci
Copy link
Contributor

@dshokouhi I created an issue for the aforementioned bug: #2703

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sensor-tracking settings
Projects
None yet
2 participants