New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using of additional notification keys requires duplication of 'Message' & 'Title' service data #349
Comments
Confirming this issue. Home Assistant Android version: 1.6.0 Description of problem: Previously Working
Current Behaviour Current workaround
|
Does that workaround work when the application is open or only when it's closed? |
Just tested it - works when the app is open and closed. |
So after digging into this for a bit I think we need to, for now, restrict what can be sent via push. We should only allow what we truly support. Because of the data you are sending you are bypassing our on device handling of the message. This is going to cause issues and confusion when you go to implement actionable notifications in the future. These are the options that we support currently:
The only required field is message, everything else is optional. |
For what it's worth, I was able to setup actionable notifications successfully even with the workaround. Didn't do any robust testing around it, just a POC. Make sense to limit to only what's supported though. |
It would be nice then to allow other parameters to be sent/used, like tag. |
@JBassett |
Sticky is another useful one - great for allowing a notification to stay after being clicked (swipe to dismiss) |
It's actually my fault, I should have put together better documentation on what the scheme for sending notifications is. I have a PR on the server side to restrict to known data fields the application can handle: home-assistant/mobile-apps-fcm-push#5
Obviously this will reduce some functionality for now. If you have a need for additional notification functionality then we should add proper support (enhancement request) for it rather than rely on the system to handle it, because it can be inconsistent. |
Half of my notification-based actions rely on tag right now and I've moved those to app. |
+1 for sticky, color, and tag |
What about sending with icon? This is very important add-on |
Home Assistant Android version: 1.6.0
Android version: 10
Phone model: Pixel 2XL
Home Assistant version: 0.105.2
Description of problem:
When using notification keys such as 'tag' or 'color' (I suspect this was never formally support yet..) the 'Message' & 'Title' keys aren't being passed through and thus need to be replaced in the data > android > notification part of the payload.
Previously Working
Current Behaviour
Notification sends, but title & message are missing. I believe in using these keys within data > android > notification, it is now also looking for 'body' & 'title' keys within to provide the message and title.
Current workaround
(Note that some dummy text needs to be inputted into the 'message' & 'title' keys as the service won't work without them). Using this workaround will continue to allow support for using of Notification Tags which are a useful feature.
The text was updated successfully, but these errors were encountered: