Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ring camera should not load when there is no cloud subscription #10736

Closed
arsaboo opened this issue Nov 21, 2017 · 2 comments · Fixed by #10739
Closed

Ring camera should not load when there is no cloud subscription #10736

arsaboo opened this issue Nov 21, 2017 · 2 comments · Fixed by #10739

Comments

@arsaboo
Copy link
Contributor

arsaboo commented Nov 21, 2017

Home Assistant release (hass --version): 0.58.1

Python release (python3 --version): 3.6

Component/platform: Ring Camera

Description of problem: Looks like Ring is blocking the camera component when there is no cloud subscription. In such cases, the Ring camera component shows Image not available. It will nice if the Ring camera can check for subscription and only load if there is a subscription. If there is no subscription, it should just log an error or create a notification.

This has also been reported in the forums. See here.
cc: @tchellomello

@tchellomello
Copy link
Contributor

Hello @arsaboo,
Yes on a recent update it seems that Ring is enforcing the subscription in order to see the video_url attribute.
I'm going to update the ring code to don't even try to load the camera.ring if the account does not have a subscription.
I'll work on it tonight.
mmello

@tchellomello
Copy link
Contributor

Guys, just testing an account that has subscription and other does not we can see the problem:

In [12]: not_subscription.recording_url(not_subscription.last_recording_id)
Out[12]: False

In [13]: has_subscription.recording_url(has_subscription.last_recording_id)
Out[13]: 'https://ring-transcoded-videos.s3.amazonaws.com/6490927797489893075.mp4?X-Amz-Expires=3600&X-Amz-Date=20171121T230526Z&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAJU3<REDACTED>.....'

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants