Counter sensors are not restored after a restart

[romain38]

Home Assistant release (hass --version):
0.59.2 / 0.60.0 / 0.61.1 / 0.70.0

Python release (python3 --version):
3.6.3

Component/platform:
Counter

Description of problem:
After each restart all counters values are lost.

Expected:
Previous counter values are restored.

Problem-relevant configuration.yaml entries and steps to reproduce:

counter:
  with_initial:
    initial: 10
    step: 1
  without_initial:
    step: 1

1. Start Home-Assistant
2. counter.with_initial is set to 10, counter.without_initial is set to 0
3. Call counter.increment service for each counter
4. counter.with_initial is set to 11, counter.without_initial is set to 1
5. Restart Home-Assistant
6. counter.with_initial is set to 10, counter.without_initial is set to 0

[romain38]

Link from discussion on community forum: https://community.home-assistant.io/t/persistent-counters/33621/9

Regards,

Romain.

[ajfriesen]

I am running Hass.io on version 0.60.0 and the conter does not restore itself when I restart Home Assistant.

[ajfriesen]

Ok, I had some time at the weekend and did install a local dev environment for home assistant.
I added a counter without an initial value. Started home assistant in GUI mode. Incremented the counter. Restart. Checked the value which was wrong.
The counter definitely does not restore the state after a restart.

I tried to look through the code but my python is still at the very beginning.

[mbevilacqua]

Still an issue on 0.61.1

[grahampowell]

I noticed that even if you don't set an initial: value, it defaults back to zero. Could we use a template value for initial:? perhaps from an mqtt feed?

[balloobbot]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.

Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍

[romain38]

This issue is still present on the latest version (v0.70.0).

Regards,

Romain.

[mvn23]

Looks like the issue is in home-assistant/homeassistant/components/counter/__init__.py line 132:
self._state = state and state.state == state always evaluates to False rather than an integer value.
For me, replacing this line with self._state = state.state seems to fix the issue, but this has not been tested extensively. Maybe @fabaff can take a look at this suggestion?

Edit: already found one problem with this solution, state.state should be cast to an int when assigning to self._state

Another edit: Disregard this comment, there's a bit more to it. I may file a PR soon.