Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Motion Blinds integration error setting up TDBU devices #110755

Closed
EDelsman opened this issue Feb 16, 2024 · 20 comments · Fixed by #110871
Closed

Motion Blinds integration error setting up TDBU devices #110755

EDelsman opened this issue Feb 16, 2024 · 20 comments · Fixed by #110871

Comments

@EDelsman
Copy link

The problem

All blinds are unavailable because of an exception when setting up TDBU devices:

Error while setting up motion_blinds platform for cover
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 344, in _async_setup_platform
await asyncio.shield(task)
File "/usr/src/homeassistant/homeassistant/components/motion_blinds/cover.py", line 124, in async_setup_entry
MotionTDBUDevice(
File "/usr/src/homeassistant/homeassistant/components/motion_blinds/cover.py", line 403, in init
delattr(self, "_attr_name")
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 335, in _deleter
delattr(o, private_attr_name)
AttributeError: 'MotionTDBUDevice' object has no attribute '__attr_name'

What version of Home Assistant Core has the issue?

2024.2.2

What was the last working version of Home Assistant Core?

2024.2.1

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Motion Blinds

Link to integration documentation on our website

https://www.home-assistant.io/integrations/motion_blinds/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

@home-assistant
Copy link

Hey there @starkillerOG, mind taking a look at this issue as it has been labeled with an integration (motion_blinds) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of motion_blinds can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign motion_blinds Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


motion_blinds documentation
motion_blinds source
(message by IssueLinks)

@taugusti
Copy link

Same experience here since installing 2.2 last night.
Removing and reinstalling the addon, reconnected the devices but without the up/down controls.

@EDelsman
Copy link
Author

I'd rather avoid removing the integration as I renamed a lot of blinds when I started with HA. I gave them cryptic names because I do not want the entities to be called directly (I have templates that block movement commands when windows are open and things like that). For now I reverted to 2024.2.1

@taugusti
Copy link

I'd rather avoid removing the integration as I renamed a lot of blinds when I started with HA. I gave them cryptic names because I do not want the entities to be called directly (I have templates that block movement commands when windows are open and things like that). For now I reverted to 2024.2.1

Same here 👍

@dylango
Copy link

dylango commented Feb 17, 2024

same here.

@soulctcher
Copy link

Woke up to this issue as well.

@brianhenk
Copy link

Also lost controls on all blinds, including just top down. Battery is still visible.

@starkillerOG
Copy link
Contributor

My appologies, I caused this bug while trying to fix an naming issue with the TDBU blinds.
I have confirmed the issue and made a fix in PR: #110871
I have tagged this for the HA 2023.2.3 patch release.

Please revert to HA 2023.2.1 If you want to get the motionblinds integration working again if you have TDBU blinds.
Once HA 2023.2.3 is released you can upgrade to that and that schould resolve the issue.

If you appreciate the motion_blinds integration and want to support its development, please consider sponsering the upstream library.

@jeroenw80
Copy link

Same issue , will wait for the 2.3 patch hopefully soon.

@jongbj1972
Copy link

I just saw that the error with 2024.2.2 also affects my Venetian blinds (which are not TDBU). They are also no longer functioning.

@starkillerOG
Copy link
Contributor

@jongbj1972 but you have a TDBU on the same gateway right?
Because the TDBU fails, the integration stops setting up the other covers such as your venetian.
So should be fixed with HA 2024.2.3

@jongbj1972
Copy link

@jongbj1972 but you have a TDBU on the same gateway right? Because the TDBU fails, the integration stops setting up the other covers such as your venetian. So should be fixed with HA 2024.2.3

Yes, they are on the same gateway. I wasn't aware of this. Looking forward to updateing to 2024.2.3.

@dartheide
Copy link

Same here, i had to restore to a 2024.1.3 to resolve te problem.

@Rescla
Copy link

Rescla commented Feb 23, 2024

I've updated core to 2024.2.3, but still the same error.

Logger: motionblinds.motion_blinds
Source: /usr/local/lib/python3.12/site-packages/motionblinds/motion_blinds.py:243
First occurred: 1:41:06 PM (7 occurrences)
Last logged: 1:41:17 PM
Response from discovery is not a GetDeviceListAck but 'Report'. 

and

Logger: homeassistant.components.cover
Source: helpers/entity_platform.py:344
Integration: Cover (documentation, issues)
First occurred: 1:40:25 PM (3 occurrences)
Last logged: 1:42:32 PM

Error while setting up motion_blinds platform for cover
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 344, in _async_setup_platform
    await asyncio.shield(task)
  File "/usr/src/homeassistant/homeassistant/components/motion_blinds/cover.py", line 124, in async_setup_entry
    MotionTDBUDevice(
  File "/usr/src/homeassistant/homeassistant/components/motion_blinds/cover.py", line 403, in __init__
    delattr(self, "_attr_name")
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 335, in _deleter
    delattr(o, private_attr_name)
AttributeError: 'MotionTDBUDevice' object has no attribute '__attr_name'\

It seems like the fix will be included in 2024.3 (for now): #110871 (comment)

@EDelsman
Copy link
Author

Still happening with 2024.2.3:
Logger: homeassistant.components.cover
Source: helpers/entity_platform.py:344
Integration: Raambekleding (documentation, issues)
First occurred: 16:22:15 (1 occurrences)
Last logged: 16:22:15

Error while setting up motion_blinds platform for cover
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 344, in _async_setup_platform
await asyncio.shield(task)
File "/usr/src/homeassistant/homeassistant/components/motion_blinds/cover.py", line 124, in async_setup_entry
MotionTDBUDevice(
File "/usr/src/homeassistant/homeassistant/components/motion_blinds/cover.py", line 403, in init
delattr(self, "_attr_name")
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 335, in _deleter
delattr(o, private_attr_name)
AttributeError: 'MotionTDBUDevice' object has no attribute '__attr_name'

@EDelsman
Copy link
Author

Seems a typo: it was removed from 2024.2.3 and at the same time proposed for 2024.2.3 x I think it didn't get included and was meant to be suggested to 2024.2.4

@starkillerOG
Copy link
Contributor

Unfortunately there was a issue with getting the fix in HA 2024.2.3 due to a merge conflict.
This means it will now be included in HA 2024.3.0 instead.
HA 2024.3.0 beta will be released on Feb 28th.
HA 2024.3.0 will be released on March 6th.

In the meantime the only option is to downgrade to 2024.2.1

I am very sorry for the inconvenience.

@EDelsman
Copy link
Author

These things happen. Thanks for your effort.

@EDelsman
Copy link
Author

EDelsman commented Feb 26, 2024

2024.2.4 is out, but because this issue was closed and the merge was pulled form 2024.2.3 but is still listed as merged, it also missed this release. What needs to happen so 2024.3.0 won't suffer the same fate? I can't reopen this.

@starkillerOG
Copy link
Contributor

@EDelsman don't worry it cant be included in a patch release but is already part of the dev brach from which HA 2023.3.0 will be made

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants