Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default config (test) - Wipes out existing secrets.yaml #11213

Closed
CCOSTAN opened this issue Dec 18, 2017 · 3 comments · Fixed by #11216
Closed

Default config (test) - Wipes out existing secrets.yaml #11213

CCOSTAN opened this issue Dec 18, 2017 · 3 comments · Fixed by #11216

Comments

@CCOSTAN
Copy link
Contributor

CCOSTAN commented Dec 18, 2017

Home Assistant release (hass --version):
0.59.2

Description of problem:
while testing, I disabled my configuration.yaml to generate a new default config and it replaced the existing secrets.yaml file.

Expected:
I don't think it should replace existing files. Especially that one. :)

  1. rename/delete your configuration.yaml
  2. restart hass
  3. start restoring your secrets.yaml because it will be replaced.

Additional info:
Maybe a rename of that file to .old? I think there are plenty of scenarios where this could happen accidentally.

@cgarwood
Copy link
Member

Looking at the code, it appears this will also wipe out the groups.yaml, automations.yaml, scripts.yaml, and customize.yaml files.

https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/config.py#L224

@cgarwood
Copy link
Member

I'm working on a PR now to change this behavior

@fabaff
Copy link
Member

fabaff commented Dec 18, 2017

Similar to #10190.

@home-assistant home-assistant locked and limited conversation to collaborators Mar 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants