FRITZ!Box Tools integrations using too many executor threads

[TheFes]

The problem

After installing the 2024.4 beta I went through some tests together with @bdraco to investigate the slow startup of my system. We noticed that my system was using over 64 executor threads. After disabling the fritz integration and restarting this was reduced to 24.
(log output of profiler.log_thread_frames)

2024-03-27 21:43:02.544 CRITICAL (MainThread) [homeassistant.components.profiler] Thread [SyncWorker_63]: File "/usr/local/lib/python3.12/threading.py", line 1030, in _bootstrap
    self._bootstrap_inner()
  File "/usr/local/lib/python3.12/threading.py", line 1073, in _bootstrap_inner
    self.run()
  File "/usr/local/lib/python3.12/threading.py", line 1010, in run
    self._target(*self._args, **self._kwargs)
  File "/usr/local/lib/python3.12/concurrent/futures/thread.py", line 89, in _worker
    work_item = work_queue.get(block=True)

Nick specifically pointed out this part of the code

            for key in list(self._entity_update_functions):
                _LOGGER.debug("update entity %s", key)
                entity_data["entity_states"][
                    key
                ] = await self.hass.async_add_executor_job(
                    self._entity_update_functions[key],
                    self.fritz_status,
                    self.data["entity_states"].get(key),
                )

I was adviced to create an issue on this, as the usage of executor threads by fritz can cause issues for other processes requiring them.

What version of Home Assistant Core has the issue?

2024.4.0b0

What was the last working version of Home Assistant Core?

NA

What type of installation are you running?

Home Assistant OS

Integration causing the issue

AVM FRITZ!Box Tools

Link to integration documentation on our website

https://www.home-assistant.io/integrations/fritz/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

[home-assistant]

Hey there @mammuth, @AaronDavidSchneider, @chemelli74, @mib1185, mind taking a look at this issue as it has been labeled with an integration (fritz) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of fritz can trigger bot actions by commenting:

• @home-assistant close Closes the issue.
• @home-assistant rename Awesome new title Renames the issue.
• @home-assistant reopen Reopen the issue.
• @home-assistant unassign fritz Removes the current integration label and assignees on the issue, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

_{^{(message by CodeOwnersMention)}}

---

fritz documentation
fritz source
_{^{(message by IssueLinks)}}

[mib1185]

Because of Easter holidays, I can't check it before Monday, but will do on Monday

[mib1185]

I think it would be sufficient to put this loop into a separate function and called it once as an executer job?

core/homeassistant/components/fritz/common.py

Lines 322 to 330 in 53f2620

	for key in list(self._entity_update_functions):
	_LOGGER.debug("update entity %s", key)
	entity_data["entity_states"][
	key
	] = await self.hass.async_add_executor_job(
	self._entity_update_functions[key],
	self.fritz_status,
	self.data["entity_states"].get(key),
	)