Move System Bridge services to dedicated file #114903
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edenhaus
requested changes
May 28, 2024
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
timmo001
force-pushed
the
system-bridge-services-file
branch
from
e5b32ba
to
f2100a8
Compare
|
Rebased |
timmo001
force-pushed
the
system-bridge-services-file
branch
from
f2100a8
to
d630920
Compare
edenhaus
requested changes
Jun 18, 2024
| supports_response=SupportsResponse.ONLY, | ||
| ) | ||
| if not hass.services.has_service(DOMAIN, SERVICE_OPEN_URL): | ||
| async_setup_services(hass) |
There was a problem hiding this comment.
We should register service in async_setup and not in the async_setup_entry
Comment on lines
+219
to
+220
| if not hass.data[DOMAIN] or hass.data[DOMAIN] == {}: | ||
| async_unload_services(hass) |
There was a problem hiding this comment.
Suggested change
| if not hass.data[DOMAIN] or hass.data[DOMAIN] == {}: | |
| async_unload_services(hass) |
We should not remove services with the last config entry
Comment on lines
+263
to
+266
| @callback | ||
| def async_unload_services(hass: HomeAssistant) -> None: | ||
| """Unload System Bridge services.""" | ||
| hass.services.async_remove(DOMAIN, SERVICE_OPEN_PATH) |
There was a problem hiding this comment.
Suggested change
| @callback | |
| def async_unload_services(hass: HomeAssistant) -> None: | |
| """Unload System Bridge services.""" | |
| hass.services.async_remove(DOMAIN, SERVICE_OPEN_PATH) |
|
May return to this in future |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
The init file was getting crowded so this moves setup and unload of services into a dedicated file. No other changes made
(Tests to be added after #114896)
Type of change
Additional information
Checklist
ruff format homeassistant tests)If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: