-
-
Notifications
You must be signed in to change notification settings - Fork 29.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modbus problem in 2024.4.0 and 2024.4.1 #115114
Comments
Please add a debug log as pr modbus integration documentation. Please also reduce your config, to the essential needed to show the problem, if you want us to use time helping you, it seems fair you use time to present the problem in a short form. |
Modbus debug log is already added under the "Diagnostics information" label. |
Please reduce your config to a small one showing the problem, you cannot expect us to use time browsing through your total configuration |
Please let me see the first part of homeassistant.log, it seems you have custom_components active, and that the pymodbus library is not updated. I am trying to reproduce the problem in the first lines of the debug.log, and when I test with your setup I do not get any errors. |
According to you 2024.3.3 works...now the very strange thing is that the pymodbus library version (from where the error message comes) have NOT changed. With the log you provided I cannot reproduce your problem, meaning you either have another problem earlier or your installation is not correctly updated. |
Hi @janiversen , I can confirm that something is going wrong in modbus with latest update. Here a short piece of log. I cannot do more test because my dev raspberry is gone and I need modbus active in my production server.. I'll try to setup a new dev board in the next days. |
Yes something is going on clearly, as you can see in the log your device is not responding The "not ready frame" is something else which I will look at. |
Maybe the "not ready frame" is part of reason why device is not responding.. All my devices are up and no problems after the rollback to 2024.3.3. |
the "not ready frame" will cause setting the entity to unavialable, I am still looking into why it happens. Funny thing is that between 2024.3.3 and 2024.4.0 pymodbus is unchanged, what changed basically is that the transport level is not async, but decoding of the modbus packages etc are the same. So somewhere within that change set is something that do not work correctly. |
Hi, I just want to mention that I encountered the exact same issue (most likely) with 2024.04 and my modbus configuration. Multiple restarts and other attempts did not fix it. Rollback to 2024.3.3 solved the issue instantly. |
Me Too. Only Rollback to 2024.3.3 solved IT ! |
@pupsette and @mjunker61 the "me too" movement does not live well here, we help people who try to help themself. Did you read the release notes, there was a breaking note change, that modbus changed to async and it might cause problems. |
Modbus Error: [Connection] Not connected[AsyncModbusSerialClient /dev/ttyUSB0:0] Is it possible to switch back to sync modbus client?
|
Not sure if you're trying to drag the actual #MeToo movement through the mud here, but these are just desperate users whose setups broke. @rostislav-palivoda There is no toggle, you can only downgrade to 2024.3. Does this change to async library calls affect ordering and/or pacing of Modbus requests at all? |
Downgraded from 2024.4.2 to 2024.3.3. Modbus works. |
I am a big fan of the #MeToo movement, just not when it is misused to complain and offer no help to solve the problem. If you look in pull request #113450 The change to async do not affect the ordering/packing, and if you look carefully the library for 2024.3.3 and 2024.4.0 is the same...but since the code is faster shorter disconnects are now detected, which is correct...and there are some problem with the decoding of the packages, which is being investigated. As you say guessing do not help, apart from the fact that all these messages reduces the time I have to find the real problem. |
I read the change tekst it did not make sense to me, plus I try to keep up with the changes, for it might be the best. That said, my SMA Inverter via MODBUS is gone too, no values any-more. It is easy for people who understand it all to say read the changes, and then you should have known, or it is an easy fix. But for many it is not, and they end up with a broken entity or device. I would appreciate help on this issue, but I am afraid someone with much more insight will tell me, do your homework, sorry you are so dumb, and do not waste our time, for that is where we are these days in the HA community. |
Surely your rant is not the way to get help, but I cleared your ches5 to get it out. Please remember this is not a support forum! we only care about bugs in the product. Anyhow we made 2024.4.3 for a reason so feel free to try it. |
Dear Jan, I do see this as a bug to be honest. And it is not the first time an option previously working fine does a great disappearance, cause of a decision someone takes somewhere for whatever reason. Yes it gives a lot of people frustrations, me too, look in the forum and you see a lot of people trying to fix this newly made BUG. And I so often got answered in a vinegar pissing way as something went awry, sorry that I started in this tone, but this is probably the 5th integration that went belly up in HA for me, I always asked nicely how to solve it and has always been met with answers like this is not a help topic, this is not for beginners, did you read the breaking news and other nasty ways, developers like to answer me, so I am truly sorry to have started this way, BUT I hope you know how to fix this, even though it is not a support forum. How do we fix this? I use core 2024.4.4 now and that is when my MODBUS gave out. SO I will not downgrade to 2024.4.3 |
First of all you write on a closed issue, and nothing more happens on this issue Secondly you do not follow the guidelines on how to report a bug, we are not magicians we cannot determine/solve a bug without detailed Thirdly we do not provide help here, that is done in the forum. Have a nice day. |
Hello, just wanted to let you know (because I'm the one who created this bug ticket) that after upgading to 2024.4.4 five days ago I do not have any connection problems and I have only 2 modbus errors in the log form the first day of upgrading to 2024.4.4
So I guess all good from my side. |
The problem
After core update to 2024.4.0 Modbus fails to read data.
What version of Home Assistant Core has the issue?
2024.4.0 and 2024.4.1
What was the last working version of Home Assistant Core?
2024.3.3
What type of installation are you running?
Home Assistant OS
Integration causing the issue
komfovent.yaml
Link to integration documentation on our website
No response
Diagnostics information
modbus.log
Example YAML snippet
Anything in the logs that might be useful for us?
No response
Additional information
No response
The text was updated successfully, but these errors were encountered: