Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover toggle OpenGarage cover toggle fails #115827

Open
danepowell opened this issue Apr 18, 2024 · 1 comment
Open

Cover toggle OpenGarage cover toggle fails #115827

danepowell opened this issue Apr 18, 2024 · 1 comment

Comments

@danepowell
Copy link

The problem

Calling cover.toggle on my OpenGarage entity frequently results in a silent failure. The garage door does not respond to the toggle and there are no associated error logs. Running cover.close works just fine, and HA always has the correct state of the garage door (open or closed), so it's not confused about the door state.

This seems to be somewhat time dependent: if I haven't used HA to open the garage in a while, cover.toggle is likely to fail. But once it starts working, it works consistently for some period of time (hours) before it starts to fail again.

I've looked through the implementations of cover and opengarage, and there's one thing I find suspicious. The cover toggle code was #59233 to only toggle closed if the last toggle direction was open.

This matches my experience of having much more trouble toggling closed than toggling open (I can't recall if toggling open is a problem). But I can't deterministically trigger the bug based on this logic, i.e., by toggling the cover closed, then manually opening outside of HA, then trying to toggle closed again. I don't understand how integrations store state such as self._cover_is_last_toggle_direction_open over time, possibly there's some time-based aspect to how this is updated.

What version of Home Assistant Core has the issue?

core-2024.4.3

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Container

Integration causing the issue

opengarage

Link to integration documentation on our website

https://www.home-assistant.io/integrations/opengarage

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

The previous issue was marked as stale, but it's very much still an active bug: #91863

I'd appreciate if an integration maintainer (@Danielhiversen ?) could at least take a look this time. I've already gotten as far as I can trying to debug it.

@home-assistant
Copy link

Hey there @Danielhiversen, mind taking a look at this issue as it has been labeled with an integration (opengarage) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of opengarage can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign opengarage Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


opengarage documentation
opengarage source
(message by IssueLinks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants