Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onkyo integration does not allow unique_id with individual configuration #116756

Open
Styx85 opened this issue May 4, 2024 · 3 comments · May be fixed by #117319
Open

Onkyo integration does not allow unique_id with individual configuration #116756

Styx85 opened this issue May 4, 2024 · 3 comments · May be fixed by #117319

Comments

@Styx85
Copy link

Styx85 commented May 4, 2024

The problem

As far as I researched, the onkyo integration should already support unique_id. But for my configuration it seems not to be supported with an individual configuration.
Or is it working as intended?

What version of Home Assistant Core has the issue?

core-2024.5.0

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

onkyo

Link to integration documentation on our website

https://www.home-assistant.io/integrations/onkyo/

Diagnostics information

No response

Example YAML snippet

##spills an error
media_player:
  - platform: onkyo
    host: !secret id_onkyo
    name: Onkyo Living room
    unique_id: xxx-2797-yyy-ab48-zzz

## works and creates unique_id
media_player:
  - platform: onkyo
#    host: !secret id_onkyo
#    name: Onkyo Wohnzimmer

Anything in the logs that might be useful for us?

Invalid config for 'onkyo' from integration 'media_player' at configuration.yaml, line 74: 'unique_id' is an invalid option for 'media_player.onkyo', check: unique_id

Additional information

No response

@home-assistant
Copy link

home-assistant bot commented May 4, 2024

@dshokouhi
Copy link
Member

You don't define the unique id the integration does. Notice how that is not mentioned in the documentation?

@dshokouhi
Copy link
Member

Looks like only devices that are discovered by the integration get a unique ID, strange.

https://github.com/home-assistant/core/blob/dev/homeassistant/components/onkyo/media_player.py#L263-L268

@Nebula83 Nebula83 linked a pull request May 12, 2024 that will close this issue
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants