Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Code owner approval not working in PR with multiple codeowners. #118160

Closed
janiversen opened this issue May 26, 2024 · 1 comment
Closed

CI Code owner approval not working in PR with multiple codeowners. #118160

janiversen opened this issue May 26, 2024 · 1 comment

Comments

@janiversen
Copy link
Member

janiversen commented May 26, 2024

The problem

Our CI now checks correctly for code owner approval for integrations with platinum status, and this works well.

However if a PR affect multiple platinum integrations the first approval “shadows” missing approval from the rest.

see #118129

@thecode approved the PR while I among others asked for changes….CI gave incorrectly green light to code owner approval.

What version of Home Assistant Core has the issue?

2024.5

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Core

Integration causing the issue

CI

Link to integration documentation on our website

https://developers.home-assistant.io/docs/integration_quality_scale_index/#platinum-

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

also opened in service_hub home-assistant/service-hub#251

@frenck
Copy link
Member

frenck commented May 26, 2024

This is not the right location for this issue.

The other you've created is: home-assistant/service-hub#251

../Frenck

@frenck frenck closed this as not planned Won't fix, can't repro, duplicate, stale May 26, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants