Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression] Ping integration marks devices unavailable when DNS not resolved #119701

Closed
joel-bourquard opened this issue Jun 14, 2024 · 4 comments
Assignees

Comments

@joel-bourquard
Copy link

joel-bourquard commented Jun 14, 2024

The problem

Previously, when DNS resolution failed for a device, the Ping Integration properly reported it as offline.

But since Home Assistant Core 2024.6.2 (or possibly a bit earlier), DNS resolution failure makes the entity Unavailable.

This is a real problem because many DHCP-based resolvers (such as DNSMasq) will rightfully fail DNS resolution for offline devices, as soon as the DHCP lease has expired.

Could the prior (ideal) behavior be restored please? Or at the very least, could a setting be added?

Thanks in advance 👍😊

What version of Home Assistant Core has the issue?

2024.6.2

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Core

Integration causing the issue

Ping

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

@joel-bourquard
Copy link
Author

This might be a resurgence of an old bug that (I think) had been resolved at the time:
https://community.home-assistant.io/t/device-tracker-throws-exceptions-when-ping-platform-cant-resolve-a-dns-name/344453

@home-assistant
Copy link

Hey there @jpbede, mind taking a look at this issue as it has been labeled with an integration (ping) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of ping can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign ping Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


ping documentation
ping source
(message by IssueLinks)

@jpbede
Copy link
Member

jpbede commented Jun 14, 2024

Is fixed with the next patch release

@joel-bourquard
Copy link
Author

Is fixed with the next patch release

Wow awesome, thanks a lot! I saw your commit and it makes complete sense indeed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants