Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid version number in updater 0.66.0.beta0 #13450

Closed
VDRainer opened this issue Mar 25, 2018 · 5 comments · Fixed by #13476
Closed

Invalid version number in updater 0.66.0.beta0 #13450

VDRainer opened this issue Mar 25, 2018 · 5 comments · Fixed by #13476

Comments

@VDRainer
Copy link
Contributor

Home Assistant release (hass --version):
0.66.0.beta0

Python release (python3 --version):
3.6.3

Component/platform:
Updater

Description of problem:
Error on check new version

Traceback (if applicable):

2018-03-25 11:33:45 INFO (MainThread) [homeassistant.components.updater] Submitted analytics to Home Assistant servers. Information submitted includes {'arch': 'x86_64', 'dev': False, 'docker': False, 'os_name': 'Linux', 'python_version': '3.6.3', 'timezone': 'Europe/Berlin', 'version': '0.66.0.beta0', 'virtualenv': True, 'hassio': False, 'distribution': 'ubuntu', 'os_version': '16.04', 'huuid': 'dontknowyoushouldsee'}
2018-03-25 11:33:45 ERROR (MainThread) [homeassistant.core] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/srv/ha/lib/python3.6/site-packages/homeassistant/components/updater.py", line 109, in check_new_version
    if StrictVersion(newest) > StrictVersion(current_version):
  File "/usr/lib/python3.6/distutils/version.py", line 40, in __init__
    self.parse(vstring)
  File "/usr/lib/python3.6/distutils/version.py", line 137, in parse
    raise ValueError("invalid version number '%s'" % vstring)
ValueError: invalid version number '0.66.0.beta0'

Additional info:

@arsaboo
Copy link
Contributor

arsaboo commented Mar 25, 2018

Seeing the same.

@JonasPed1
Copy link
Contributor

Looks like the StrictVersion in distutils.version does not support version numbers that contain the word beta. In their mind beta versions should be named something like 0.66.0b0.

Would make sense to ise Setuptools instead of StrictVersion? See https://www.python.org/dev/peps/pep-0386/ for details.

@VDRainer
Copy link
Contributor Author

There's already an error with just 'b'

2018-03-27 07:28:31 ERROR (MainThread) [homeassistant.core] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/srv/ha/lib/python3.6/site-packages/homeassistant/components/updater.py", line 109, in check_new_version
    if StrictVersion(newest) > StrictVersion(current_version):
  File "/usr/lib/python3.6/distutils/version.py", line 40, in __init__
    self.parse(vstring)
  File "/usr/lib/python3.6/distutils/version.py", line 137, in parse
    raise ValueError("invalid version number '%s'" % vstring)
ValueError: invalid version number '0.66.0.b2'

@balloob
Copy link
Member

balloob commented Mar 27, 2018

Argh, I tested it locally with a different value than the value I pushed. I will remove the .

@balloob balloob reopened this Mar 27, 2018
@VDRainer
Copy link
Contributor Author

Fixed in 0.66.0b3 👍

@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants