onkyo component not working after upgrade to 0.82

[Ener-G]

Home Assistant release with the issue:
0.82.0 (running on Raspbian)

Last working Home Assistant release (if known):
0.81.6

Operating environment (Hass.io/Docker/Windows/etc.):
Raspbian

Component/platform:
onkyo
https://www.home-assistant.io/components/media_player.onkyo/

Description of problem:
After the upgrade to 0.82.0 i got this message in the log an the system is not starting:

2018-11-10 13:59:00 ERROR (MainThread) [homeassistant.components.media_player] onkyo: Error on device update!
Traceback (most recent call last):
  File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/helpers/entity_platform.py", line 251, in _async_add_entity
    await entity.async_device_update(warning=False)
  File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/helpers/entity.py", line 349, in async_device_update
    await self.hass.async_add_executor_job(self.update)
  File "/usr/lib/python3.5/asyncio/futures.py", line 380, in __iter__
    yield self  # This tells Task to wait for completion.
  File "/usr/lib/python3.5/asyncio/tasks.py", line 304, in _wakeup
    future.result()
  File "/usr/lib/python3.5/asyncio/futures.py", line 293, in result
    raise self._exception
  File "/usr/lib/python3.5/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/components/media_player/onkyo.py", line 223, in update
    self._attributes["video_out"] = ','.join(hdmi_out_raw[1])
TypeError: 'bool' object is not subscriptable

if the configuration is removed, the system works fine.

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

  - platform: onkyo
    host: 192.168.178.45
    name: Onkyo-TX-NR509
    sources:
      video1: chromecast
      video3: ps4
      video2: tv

[tubalainen]

+1 on that one!

The entity_id "media_player.onkyo_amp" is no more.
But I still got: "media_player.onkyo_amp_zone_2" and "media_player.onkyo_amp_zone_3" in the list of entities.

I am running docker under Debian.

[marcelgoertz]

+1. Same issue here. However, this does not seem to apply to the (newer) TX-NR575E amp I have; this one continues to work in Hass as before. The older 656 no longer works with Hass.

[bmesuere]

As far as I can see, the only PR that touched this component was #18081 by @leothlon. The PR indeed touches the lines that causes the error.

[bmesuere]

It seems that hdmi-output-selector query throws an exception on our devices and returns false at https://github.com/leothlon/home-assistant/blob/45ad540514018ed43687ce33e34b07e4317a8c1f/homeassistant/components/media_player/onkyo.py#L202

It seems that a check is missing in case this is false.

[leothlon]

Hi, could you try adding

if not (hdmi_out_raw):
    return

before
self._attributes["video_out"] = ','.join(hdmi_out_raw[1])
on line 223

and see if that solves it?

[leothlon]

Currently running through the tests, will send in a PR to fix it when done.
Thanks @bmesuere for bringing it to my attention.

And sorry for the inconvenience caused.

[svkowalski]

Hi!

Just installed beta 0.83.0 to see if it includes this fix. My error message no longer appears in the use case I reported: "Error messages appear when HA is started while Onkyo receiver is already turned on."

I did not see this error occur. Also, a collateral issue I had with the volume control becoming unresponsive no longer occurs.

So I can report that this fix (or some other change in this release) fixes my Onkyo issues.

Thanks to all developers involved!
~svk

[Ener-G]

Yes. Same here. With 0.83.0 beta it is working finde