New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor pihole integration #26700
Comments
+1 I too run two Pi-Holes (same ESXi host); previously had two separate sensors for each and template sensors averaging statistics across the two. This is no longer possible in the new |
I'm also running two VMs with Pi-Hole and since the upgrade I've lost the sensors for my second instance. I've attempted various configurations (two |
+1 I have tried 2 host keys, a pi_hole: and pi_hole2: and various other methods of configuraton... none worked. I was aware of the breaking change and assumed the docs would expand to 2 or more hosts. This was working perfectly under 0.98.5 for me as well. |
@johnluetke, can you take a look please? |
@jamieshaw @WhimsySpoon @mattlward The new config doesn't allow multiple hosts, that circumstance wasn't something I considered in the new implementation. I will try and redo the config once more to re-add support for that. |
Awesome, thanks for giving us the effort. It is not uncommon for pihole users to run a pair of systems. With 35 hosts on my net the secondary system sees about 5 percent of the requests. |
Thanks for looking into this so quickly. Happy to test any betas you may wish to issue. |
@WhimsySpoon I have an alpha version available if you are still willing to test it out. Unzip the files and drop them into your Here's a sample configuration pi_hole:
- host: pi.hole
- host: pi.hole:8443
ssl: True
verify_ssl: False Let me know how it goes. :-) cc: @jamieshaw @mattlward |
Naming conflict with the custom component it seems – I believe I remember reading a blog article that they no longer take precedence? 🤔
Config:
|
This is working for me on my test box with the following:
These are the template sensors I am using:
|
@johnluetke This is working perfectly for me.
|
@WhimsySpoon @daveyrb Awesome thanks! Next question: How would you want to differentiate between the two separate Pi-holes? By name? By IP/hostname? In #27055, I introduced two services that can interact with a single Pi-hole directly, under the assumption that there is only one configured in HA. However, some other identifying mechanism will need to be utilized. I'm leaning toward name, but after seeing how @daveyrb's template sensors use |
@jamieshaw Is the name of the folder in
|
@johnluetke would want to differentiate by name most definitely. |
@johnluetke How about by Those new services look really helpful; I frequently stop the PiHole services when attempting to diagnose potential issues with websites. Would it be possible to provide a name, or also have the service stop services on all Pi-holes network-wide if no name has been specified, as there may be instances where one wants to diagnose a specific Pi-Hole, or all add blocking. |
@jamieshaw I put the files in the following directory and it works for me:
|
I don't really mind as long as I can differentiate I can modify my sensors to suit. |
As copied and pasted from my terminal window; not sure why it's not wanting to play with me. 😅
UPDATE |
Might be worth updating the documentation to also include the Time to refactor again, I guess… 😂 |
Is there anything holding this back from being merged? |
Not that I'm aware of. #27569 is just still waiting to be reviewed |
Just seen your chase on it, thanks. Just wanted to make sure I wasn't keeping the custom component alive when/if it wasn't needed. |
Home Assistant release with the issue:
0.99.0b3
Last working Home Assistant release (if known):
0.98.5
Operating environment (Hass.io/Docker/Windows/etc.):
Docker
Component/platform:
#25837
Description of problem:
I currently have two Raspberry Pi's running Pi-Hole for resillience.
I then add both sensors together in a template sensor to create totals for the below from both Pi-Holes
- ads_blocked_today
- ads_percentage_today
- dns_queries_today
With the new configuration I can only enter one host.
Problem-relevant
configuration.yaml
entries and (fill out even if it seems unimportant):Traceback (if applicable):
Additional information:
The text was updated successfully, but these errors were encountered: