Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CalDAV calendars created from search queries show duplicated in "Calendar" panel #36039

Closed
3 tasks done
jamieshaw opened this issue May 23, 2020 · 10 comments · Fixed by #45701
Closed
3 tasks done

CalDAV calendars created from search queries show duplicated in "Calendar" panel #36039

jamieshaw opened this issue May 23, 2020 · 10 comments · Fixed by #45701

Comments

@jamieshaw
Copy link

Checklist

  • I have updated to the latest available Home Assistant version.
  • I have cleared the cache of my browser.
  • I have tried a different browser to see if it is related to my browser.

The problem

Calendar entities created by applying a search query to a 'master' calendar are are shown duplicated in the calendar view.

In the attached screenshot (fig. 1), three calendars pull from a single "Meals" calendar and search for all-day events prefixed with 'Breakfast:', 'Lunch:', or 'Dinner:' for respectively named calendar. The main "Meals" calendar isn't imported into Home Assistant, opting for the separated ones in it's place. Under the new Calendar panel, the "Breakfast" and "Lunch" calendar are showing "Dinner" events, despite not being actually active in their respective calendar. entities (fig. 2).

Screenshot 2020-05-23 at 1 02 01 pm
Figure 1

Screenshot 2020-05-23 at 1 06 12 pm
Figure 2

Expected behavior

Calendars should only show events for that particular calendar. entity.

Steps to reproduce

  1. Add searchable event to CalDAV calendar (i.e. iCloud)
  2. Create a calendar component from the CalDAV URL
  3. Create child calendars using the search query (one positive, one negative)
  4. Hide the parent calendar (do not import into Home Assistant)
  5. Observe the calendar panel
  6. Witness child calendars show all events from parents, and are not filtered.

Environment

  • Home Assistant release with the issue: 0.110.x
  • Last working Home Assistant release (if known): N/A
  • Browser and browser version: Edge 83.0.478.37
  • Operating system: macOS 10.15.4

State of relevant entities

calendar.meals_breakfast
  state: off	
  offset_reached: false
  friendly_name: Breakfast

calendar.meals_dinner
  state: on
  message: Dinner: Fish and Chips
  all_day: true
  start_time: 2020-05-23 00:00:00
  end_time: 2020-05-24 00:00:00
  location: null
  description: null
  offset_reached: false
  friendly_name: Dinner

calendar.meals_lunch
  state: off	
  offset_reached: false
  friendly_name: Lunch

Problem-relevant configuration

- name: 'Breakfast'
  calendar: &meal_calendar
      Meals
  search: '^\s*[Bb]reakfast[:]'

- name: 'Lunch'
  calendar: *meal_calendar
  search: '^\s*[Ll]unch[:]'

- name: 'Dinner'
  calendar: *meal_calendar
  search: '^\s*[Dd]inner[:]'

Javascript errors shown in your browser console/inspector

N/A

Additional information

@bramkragten
Copy link
Member

That is the custom_calendars options of CalDAV?

This is an issue with the CalDAV integration, it should only return the events that match your search.

@bramkragten bramkragten transferred this issue from home-assistant/frontend May 23, 2020
@probot-home-assistant
Copy link

caldav documentation
caldav source
(message by IssueLinks)

@bramkragten bramkragten changed the title Calendars created from search queries show duplicated in "Calendar" panel CalDAV calendars created from search queries show duplicated in "Calendar" panel May 23, 2020
@onkelbeh
Copy link
Contributor

Same here, I have one Calendar containing info for 3 different garbage bins. Every calendar shows an entry under "My Calendars", but it shows all appointments ignoring the search criteria.

@onkelbeh
Copy link
Contributor

'Problem' persists in 0.110.2.

@ronytomen
Copy link
Contributor

Version 0.110.3 still an issue.

calendar:
  # iCloud Calendar Definitions
  - platform: caldav
    url: !secret icloud_url
    username: !secret icloud_username
    password: !secret icloud_app_specific_password
    custom_calendars:
      - name: 'Holiday'
        calendar: 'Automation'
        search: '^(Holiday|HOLIDAY)'
      - name: 'Notice'
        calendar: 'Automation'
        search: '^Notice:'
      - name: 'Payday'
        calendar: 'Automation'
        search: '^(PayDay|Payday)'
      - name: 'PTO'
        calendar: 'Automation'
        search: '^(PTO|Pto|pto)'
      - name: 'Travel'
        calendar: 'Automation'
        search: '^(Travel|TRAVEL)'

Any of these have events, then they show for every other defined calendar as well. This might simply be an issue with the Calendar panel not handling multiple calendars? I have not dived in to debug it yet.

@onkelbeh
Copy link
Contributor

Just browsed by, again, still the same with 0.114.3

@onkelbeh
Copy link
Contributor

onkelbeh commented Sep 2, 2020

and 0.114.4
:-)

@yellowonblack
Copy link

yellowonblack commented Sep 15, 2020

Confirm the same problem with duplicated events on the last version 0.114.4.

The same problem from other users here https://community.home-assistant.io/t/caldav-doesnt-generate-binary-sensors/204994/3

@yellowonblack
Copy link

The issue still present in 0.115.2 and also in the new Lovelace calendar card https://www.home-assistant.io/blog/2020/09/17/release-115/#calendar-card

@hassio-lars
Copy link

hassio-lars commented Dec 18, 2020

The issue is still present in 2020.12.7 in both the calendar panel and in Lovelace calendar card. Im totally unfamiliar with Github, but to me it seems there are no pull requests that address this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants