-
-
Notifications
You must be signed in to change notification settings - Fork 29.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Climate component reports wrong unit when converting between C - F #3605
Comments
Not sure why this is closed. #3755 is a first good stab at this. Reopening. |
Oh sorry, the wrong issue. I have to close a other. |
I was looking at this in a little more detail as it relates to ecobee. As far as the ecobee api is concerned, everything seems to come back in F. The 'useCelsius' flag (which is True in my results) appears to simply mean the user has set Celsius and everything should be presented that way, but the data in the json object is Fahrenheit. As such the way the ecobee climate module implements this as written appears to be incorrect. |
Is this solved for everyone now with 0.31? |
@turbokongen looks good for me now.. |
Excellent! |
Home Assistant release (
hass --version
): 0.29.4Python release (
python3 --version
): AllComponent/platform: Climate
Description of problem:
The Climate component reports more than just a state in a specified unit. This is not a case that the automatic conversion of the Entity class can handle.
This results in that the Climate component will convert Celsius correctly to Fahrenheit but it will still show C as unit of measurement in the state and UI (and other way around too).
For this to be fixed, we should do the following steps:
unit_of_measurement
property should be owned by the climate ABC and be equal toself.hass.config.units.temperature_unit
temperature_unit
)ClimateEntity._convert_for_display
passself.temperature_unit
instead ofself.unit_of_measurement
toconvert_temperature
.The text was updated successfully, but these errors were encountered: