Invalid time pattern passes checks

[DubhAd]

The problem

An invalid time pattern trigger passes the config checks, but will throw errors at run time.

Environment

• Home Assistant Core release with the issue: 0.115.0
• Last working Home Assistant Core release (if known):
• Operating environment (OS/Container/Supervised/Core): Core
• Integration causing this issue: Automation
• Link to integration documentation on our website: https://home-assistant.io/integrations/automation

Problem-relevant configuration.yaml

- id: '1572617131931'
  alias: New Automation
  description: ''
  trigger:
  - platform: time_pattern
    seconds: '/300'
  condition: []
  action:
  - data:
      message: "Test here"
    service: notify.file

Traceback/Error logs

Additional information

[DubhAd]

During startup you get the following from the above automation:

2020-09-18 20:54:01 ERROR (MainThread) [homeassistant.config] Invalid config for [automation]: must be a value between 0 and 59 for dictionary value @ data['seconds']. Got None. (See /home/homeassistant/.homeassistant/configuration.yaml, line 63).

[probot-home-assistant]

automation documentation
automation source
_{^{(message by IssueLinks)}}

[probot-home-assistant]

Hey there @home-assistant/core, mind taking a look at this issue as its been labeled with an integration (automation) you are listed as a codeowner for? Thanks!
_{^{(message by CodeOwnersMention)}}

[spacegaier]

I can't reproduce that in the latest 0.116 dev branch. During attempted saving in the automation editor, it correctly raises the error that the value is not valid.

[DubhAd]

The automation editor may complain, but that doesn't help:

1. Those who write them manually
2. Those who already have invalid values ;)

See also this thread

[spacegaier]

@DubhAd If I manually change the values of the automation in YAML and then reload from within HA then I get the same error logged as you. What would be the expected outcome? To me the error looks correct (would be better if instead of "None" it would show "300").

[DubhAd]

Sorry for the delay. The problem is there's no error from the config check, only at startup.

[balloob]

The problem is that "check config" was a hack bolted onto Home Assistant that we now have to maintain and hasn't kept up with the modernizing of config validation 😭

[balloob]

This will happen to anything that uses the modern config validation, which includes anything that has triggers, conditions or action/scripts. To fix this helpers/check_config.py should be changed to use async_process_component_config from homeassistant/config.py for validation.

[github-actions]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.