Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasmota integration: user defined transition time not used for scenes #43381

Closed
maichai opened this issue Nov 19, 2020 · 5 comments
Closed

Tasmota integration: user defined transition time not used for scenes #43381

maichai opened this issue Nov 19, 2020 · 5 comments
Assignees

Comments

@maichai
Copy link

maichai commented Nov 19, 2020

The problem

Tasmota integration:

I tested 2 Tasmota lights (identical vendor and model and firmware Tasmota 9.1), 1 light with through Tasmota integration and 1 light through my own MQTT light Template.

For my own MQTT template integration transitions have always worked in all variations, it is implemented like this:

     {%- if transition is defined -%}
      fade 1; speed {{ transition |round |int * 2 }}; 
      {%- endif -%}

The automation descried below does a 4s transition between two light scenes with different colors. For my own integration the transition takes 4s and is very smooth. The new Tasmota integration uses a very short transition (i think shorter than 1s).

So the Problem is that the integration does not seem to use the transition time defined by the user, but something else. (I have not checked the source code of the integration.)

It would be really nice if the user define transition duration would be used so tht I could get rid of the numerous mqtt integrations for all my lights. It is a pain to maintain...

Environment

  • Home Assistant Core release with the issue: 0.118.0
  • Last working Home Assistant Core release (if known): unknown
  • Operating environment (OS/Container/Supervised/Core): HASS OS
  • Integration causing this issue: Tasmota (beta) with Tasmota 9.1 light
  • Link to integration documentation on our website: https://www.home-assistant.io/integrations/tasmota

Problem-relevant configuration.yaml

an automation to switch between 2 light scenes with different colors

  alias: test
  description: ''
  trigger:
  - platform: time_pattern
    seconds: /10
  condition: []
  action:
  - data:
      transition: 4
    entity_id: scene.test1
    service: scene.turn_on
  - delay: 00:00:05
  - data:
      transition: 4
    entity_id: scene.test2
    service: scene.turn_on
  - delay: 00:00:05
  mode: single

Traceback/Error logs

none

Additional information

@probot-home-assistant
Copy link

Hey there @emontnemery, mind taking a look at this issue as its been labeled with an integration (tasmota) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@emontnemery
Copy link
Contributor

Home Assistant's transition is the transition time in seconds.
On the other hand, Tasmota's speed command is the number of half-seconds scaled for a 100% fade.
This means with a speed of 10, changing from dimmer from 0..100 will need 5 seconds, but changing from 50..100 will only need 2.5 seconds.

Currently HATasmota only considers brightness when converting transition to Tasmota speed color and color temperature needs to be considered as well.

@emontnemery
Copy link
Contributor

Here's an attempt to fix the transitions: emontnemery/hatasmota#51
@maichai can you give it a try?

@maichai
Copy link
Author

maichai commented Nov 21, 2020

lovely, but I am not sure what I need to do for that, sorry. Can you give me a hint or pointer what to do?

@emontnemery
Copy link
Contributor

OK, it's implemented here: #43608, so will land in HA 0.119

@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants