Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google calendar integration docs say read-only access is given, but actually requests read/write #45229

Closed
SadGamerGeek opened this issue Jan 16, 2021 · 4 comments

Comments

@SadGamerGeek
Copy link

The problem

The google calendar integration docs say:

This will grant your Home Assistant service read-only access to all the Google Calendars that the account you authenticate with can read.

After taking the steps to set-up the integration though, the Google authentication prompt shows:

Home Assistant wants to access your Google Account

This will allow Home Assistant to:

See, edit, share and permanently delete all the calendars that you can access using Google Calendar

Clicking for further info shows:

This app wants permission to make changes to your calendars, as well as any calendar you can access using your Google Calendar, including:

Create, change or delete calendars
Update individual calendar events
Change your settings, including who can see your events
Change who the calendar is shared with
Your calendars and other calendars you access may contain info like daily schedules, personal contacts and private appointments.

As well as contradicting the documentation, this seems like a bad thing!

After discovering this myself, a search revealed other people have hit this as well:

https://community.home-assistant.io/t/google-calendar-read-only-access/156253

User daveinc in that community post seems to have worked out what's happening/needed:

Documentation here suggests that we we should be hitting
https://www.googleapis.com/auth/calendar.readonly
but looking at the source, we might actually be hitting
https://www.googleapis.com/auth/calendar

Environment

  • Home Assistant Core release with the issue: 2021.1.3
  • Last working Home Assistant Core release (if known): unknown
  • Operating environment (OS/Container/Supervised/Core): OS
  • Integration causing this issue: google calendar
  • Link to integration documentation on our website: https://www.home-assistant.io/integrations/calendar.google/

Problem-relevant configuration.yaml

Traceback/Error logs

Additional information

@probot-home-assistant
Copy link

google documentation
google source
(message by IssueLinks)

@BottlecapDave
Copy link
Contributor

I posted the original issue in the forums. I'm assuming this change was made originally to support the add_event service.
It would be really nice to have an option in the config to determine access (read or readwrite; defaults to readwrite) which in turn would request the correct scopes and determine if this add_event service was available.

That way for us that want more restricted access, we can have it and for those that want more features (and without breaking existing functionality) it would support them too.

@BottlecapDave
Copy link
Contributor

If resourcing is an issue, I wouldn't mind taking a look with a pull request

@github-actions
Copy link

github-actions bot commented May 7, 2021

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 7, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants