Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in log when using local notifications with mobile_app using the 2021.7 iOS beta app #52038

Closed
rccoleman opened this issue Jun 20, 2021 · 2 comments · Fixed by #52039
Closed

Comments

@rccoleman
Copy link
Contributor

The problem

Using the new local notification feature of the 2021.7 beta version of the iOS app, I get the following error in the log when joining my local Wifi network and the iOS app refreshes:

2021-06-20 12:05:45 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection] [139965000796624] Error handling message: Unknown error
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/websocket_api/connection.py", line 100, in async_handle
    handler(self.hass, self, schema(msg))
  File "/usr/src/homeassistant/homeassistant/components/mobile_app/__init__.py", line 163, in handle_push_notification_channel
    registered_channels.pop(webhook_id)()
TypeError: forward_push_notification() missing 1 required positional argument: 'data'

Seems to be related to #50750, and specifically this:

registered_channels.pop(webhook_id)()

this:

registered_channels[webhook_id] = forward_push_notification

and this:

def forward_push_notification(data):

What is version of Home Assistant Core has the issue?

core-2021.6.5

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

mobile_app

Link to integration documentation on our website

https://www.home-assistant.io/integrations/mobile_app/

Example YAML snippet

No response

Anything in the logs that might be useful for us?

As above:


2021-06-20 12:05:45 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection] [139965000796624] Error handling message: Unknown error
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/websocket_api/connection.py", line 100, in async_handle
    handler(self.hass, self, schema(msg))
  File "/usr/src/homeassistant/homeassistant/components/mobile_app/__init__.py", line 163, in handle_push_notification_channel
    registered_channels.pop(webhook_id)()
TypeError: forward_push_notification() missing 1 required positional argument: 'data'

Happens when switching to the local wifi network from the cellular network on my iPhone when using the just-released 2021.7 beta of the iOS app.



### Additional information

_No response_
@probot-home-assistant
Copy link

mobile_app documentation
mobile_app source
(message by IssueLinks)

@rccoleman rccoleman changed the title Error in log when using local notifications with mobile_app Error in log when using local notifications with mobile_app using the 2021.7 iOS beta app Jun 20, 2021
@probot-home-assistant
Copy link

Hey there @robbiet480, mind taking a look at this issue as its been labeled with an integration (mobile_app) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@balloob balloob linked a pull request Jun 20, 2021 that will close this issue
21 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants