Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Calendar omits events #54158

Closed
Bert-R opened this issue Aug 6, 2021 · 1 comment · Fixed by #54231
Closed

Google Calendar omits events #54158

Bert-R opened this issue Aug 6, 2021 · 1 comment · Fixed by #54231

Comments

@Bert-R
Copy link

Bert-R commented Aug 6, 2021

The problem

The Google Calendar integration has a setting max_results, which is 5 by default. When fetching the events for a date interval, it fetches at most max_results events, silently skipping others. This issue has bothered several users, see the community.

Though this is apparently by design, it's not what users expect and it's easy to fix. See "Additional information" below. I'm willing to contribute a fix.

What is version of Home Assistant Core has the issue?

core-2021.8.1

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Google Calendar Event

Link to integration documentation on our website

https://www.home-assistant.io/integrations/calendar.google/

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

The max_results setting is passed to the Google Calendar Events list API. That API applies 250 as a default value. If Home Assistant would use that same value, a lot less users would face an issue with missing entries.

Even better would be to make Home Assistant iterate through the pages, based on the nextPageToken that's returned when a next page exists.

I'm willing to contribute a fix but as I'm new to Home Assistant, I would like to hear from the code owner whether the above approach is valid or whether higher layers (e.g. the CalendarEventDevice base class) would have an issue with a significant number of events is returned.

@probot-home-assistant
Copy link

google documentation
google source
(message by IssueLinks)

@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant