Fibaro light/rgbw controller brightness controls throwing exceptions, making the entity unusable #55386
Comments
|
fibaro documentation |
|
So, small update. Consider the following exception: So this happens when an 'update' (state) is triggered, device gets registered, etc. The reason this will happen must be that the # from components/fibaro/light.py
@property
def brightness(self):
"""Return the brightness of the light."""
return scaleto255(self._brightness)
def scaleto255(value):
"""Scale the input value from 0-100 to 0-255."""
# Fibaro has a funny way of storing brightness either 0-100 or 0-99
# depending on device type (e.g. dimmer vs led)
if value > 98: #<<<the offending code
value = 100
return max(0, min(255, ((value * 255.0) / 100.0)))# from components/light/__init__.py
def state_attributes(self):
"""Return state attributes."""
#... code shortened
if color_mode in COLOR_MODES_BRIGHTNESS:
data[ATTR_BRIGHTNESS] = self.brightness #<<< reason it fails
elif supported_features & SUPPORT_BRIGHTNESS:
# Backwards compatibility for ambiguous / incomplete states
# Add warning in 2021.6, remove in 2021.10 <<< warning not in logs, so I'm assuming this code is not hit
data[ATTR_BRIGHTNESS] = self.brightnessSo, main question then: Why is the brightness-flag not set? Since this is a rgbw-controller, which obviously has brightness control. {
"id": 59,
"name": "Garden",
"roomID": 221,
"view": [
{
"assetsPath": "/assets/icon",
"jsPath": "/dynamic-plugins/com.fibaro.colorController",
"name": "com.fibaro.colorController",
"translatesPath": "/dynamic-plugins/com.fibaro.colorController/i18n",
"type": "ts"
},
{
"assetsPath": "/assets/icon",
"jsPath": "/dynamic-plugins/level-change",
"name": "level-change",
"translatesPath": "/dynamic-plugins/level-change/i18n",
"type": "ts"
}
],
"type": "com.fibaro.FGRGBW442CC",
"baseType": "com.fibaro.colorController",
"enabled": true,
"visible": true,
"isPlugin": false,
"parentId": 56,
"viewXml": false,
"configXml": false,
"interfaces": [
"levelChange",
"light",
"zwave",
"zwaveAlarm",
"zwaveMultiChannelAssociation",
"zwaveProtection"
],
"properties": {
"pollingTimeSec": 0,
"zwaveCompany": "Fibargroup",
"zwaveInfo": "3,6,4",
"zwaveVersion": "5.0",
"RFProtectionState": 0,
"RFProtectionSupport": 3,
"alarmLevel": 0,
"alarmType": 0,
"categories": [
"lights"
],
"color": "255,98,0,0",
"colorComponents": {},
"configured": true,
"currentProgram": 0,
"currentProgramID": 0,
"dead": false,
"deadReason": "",
"deviceControlType": 50,
"deviceIcon": 15,
"endPointId": 1,
"isLight": true,
"localProtectionState": 0,
"localProtectionSupport": 5,
"log": "",
"logTemp": "",
"manufacturer": "",
"markAsDead": true,
"model": "",
"nodeId": 6,
"parametersTemplate": 849,
"productInfo": "1,15,9,2,16,0,5,0",
"programsSortOrder": "1,2,3,4,5",
"protectionExclusiveControl": 0,
"protectionExclusiveControlSupport": false,
"protectionState": 0,
"protectionTimeout": 0,
"protectionTimeoutSupport": false,
"saveLogs": true,
"serialNumber": "h'0000000000007b10",
"state": false,
"useTemplate": true,
"userDescription": "",
"value": 0
},
"actions": {
"reconfigure": 0,
"setColor": 1,
"setColorComponents": 1,
"setValue": 1,
"startColorEnhancement": 1,
"startColorFade": 1,
"startLevelDecrease": 0,
"startLevelIncrease": 0,
"startProgram": 1,
"stopColorChange": 1,
"stopLevelChange": 0,
"toggle": 0,
"turnOff": 0,
"turnOn": 0
},
"created": 1626628598,
"modified": 1626628598,
"sortOrder": 44
}As you can see, this is roughly what the current HA code expects: it has Now, the following is the Fibaro API output from the location running the HC3 with software version v5.080.x: {
"id": 101,
"name": "L_Back",
"roomID": 220,
"view": [
{
"assetsPath": "/assets/icon",
"jsPath": "/dynamic-plugins/com.fibaro.colorController",
"name": "com.fibaro.colorController",
"translatesPath": "/dynamic-plugins/com.fibaro.colorController/i18n",
"type": "ts"
}
],
"type": "com.fibaro.FGRGBW442CC",
"baseType": "com.fibaro.colorController",
"enabled": true,
"visible": true,
"isPlugin": false,
"parentId": 97,
"viewXml": false,
"configXml": false,
"interfaces": [
"light",
"notification",
"parameters",
"zwave"
],
"properties": {
"pollingTimeSec": 0,
"zwaveCompany": "Fibargroup",
"zwaveInfo": "3,6,4",
"zwaveVersion": "5.0",
"categories": [
"lights"
],
"color": "255,63,0,0",
"colorComponents": {
"blue": 0,
"green": 63,
"red": 255,
"warmWhite": 0
},
"configured": true,
"currentProgram": 0,
"currentProgramID": 0,
"dead": false,
"deadReason": "",
"deviceControlType": 23,
"deviceIcon": 15,
"endPointId": 1,
"isLight": true,
"log": "",
"logTemp": "",
"manufacturer": "",
"markAsDead": true,
"model": "",
"nodeId": 16,
"parameterProvider": "zwave",
"parametersTemplate": 0,
"productInfo": "1,15,9,2,16,0,5,0",
"programsSortOrder": "1,2,3,4,5",
"saveLogs": true,
"serialNumber": "",
"state": false,
"supportedNotifications": {
"8": {
"eventValues": {},
"key": "blockScenes.notification.properties.8",
"stateValues": {
"over-current-status": {
"key": "blockScenes.notification.properties.over-current-status",
"values": {
"0": {
"key": "blockScenes.notification.properties.8.0",
"saveToPanel": true
},
"6": {
"key": "blockScenes.notification.properties.8.6",
"saveToPanel": true
}
}
}
}
},
"9": {
"eventValues": {},
"key": "blockScenes.notification.properties.9",
"stateValues": {
"hw-status": {
"key": "blockScenes.notification.properties.hw-status",
"values": {
"0": {
"key": "blockScenes.notification.properties.9.0",
"saveToPanel": true
},
"3": {
"key": "blockScenes.notification.properties.9.3",
"saveToPanel": true
}
}
}
}
}
},
"useTemplate": true,
"userDescription": "",
"value": 0
},
"actions": {
"reconfigure": 0,
"setColor": 1,
"setColorComponents": 1,
"setValue": 1,
"startColorEnhancement": 1,
"startColorFade": 1,
"startProgram": 1,
"stopColorChange": 1,
"toggle": 0,
"turnOff": 0,
"turnOn": 0
},
"created": 1629830995,
"modified": 1629830995,
"sortOrder": 30
}In this case, the interfaces array does not contain the So, to check this, I've changed the code locally to change the way it detects the capabilities. Code was changed to this: #components/fibaro/light.py in __init__ (code truncated)
supports_dimming = (
"levelChange" in fibaro_device.interfaces
or supports_color #this change will enable brightness control
)
supports_white_v = (
"setW" in fibaro_device.actions
or fibaro_device.type == "com.fibaro.FGRGBW442CC" #this change enables white-level control
)
# Configuration can override default capability detection
if devconf.get(CONF_DIMMING, supports_dimming):
self._supported_flags |= SUPPORT_BRIGHTNESS #the change causes this line and...
if devconf.get(CONF_COLOR, supports_color):
self._supported_flags |= SUPPORT_COLOR
if devconf.get(CONF_WHITE_VALUE, supports_white_v):
self._supported_flags |= SUPPORT_WHITE_VALUE #...this line to now get executedAnd sure enough, when this was changed, the light gets detected properly, we get on/off, brightness, color and white level control! |
|
Second update, confirmed that this exception is also breaking functionality for switch-like devices (such as a Fibaro Double Switch), these show up as "binary switch" however, if the property Now, if I forcibly add the |
|
Workaround (for light devices that have the ability to set brightness): as a (very ugly, if I might add) workaround, if you run into this issue:
Once you've done that, you should at least get the basic functionality from the device in Home Assistant ;) (Beware though, this will only work for actual lights, not for switches, if you have this problem with a switch, make sure its |
|
Bump. Waiting for PR to come through, waiting for maintainer to approve CI workflow? |
|
Very keen to see this fixed too. |
|
FYI, this was released in 2021.11.0, confirmed fixed as of that version :) |
|
I’ve been watching closely too. Confirming working here in 2021.10.7 too. Thanks again for your work. |
The problem
Main problem
Fibaro rgbw lights brightness control broken, will throw an exception about
NoneTypenot being anintegerExpected behavior
Light works as intended and shows on/off, brightness and color controls*
Actual behavior
Light either does not function at all or will only operate the on/off and color functions*
thrown exception (excerpt):
'>' not supported between instances of 'nonetype' and 'int'*see details and gifs below for more clarity
Details:
Whilst setting up a new system we got to including the existing Fibaro stuff (which is running on an Home Center 3, latest software as of this writing, which is 5.080.x), however, this starts throwing exceptions regarding the brightness attribute.
Although the system did actually register the devices, we're not able to control them.
That is to say: sometimes it'll pop on and will give on/off and color controls, but it won't give brightness controls. Other times, it simply refuses to turn on at all.
In both cases, an exception gets thrown when the code tries to set the brightness level.
In all fairness, there's only one that I'll get to turn on, which is only because I've tinkered with it through the developer tools to "force" it's brightness value to 100, once I'd do that, I'd get on/off and color control (although it remains flaky, at best).
Now, in another location, we have similar setup, but on that location the entire setup works flawesly.
There's 2 differences on that location: 1) uses an HC3 Lite instead of a full-fledged HC3, 2) the Fibaro software version is 5.070.x, e.g. one minor lower.
What was tried to fix it
Now, I've tried the following things in an effort to fix the issue (none of them worked):
The exceptions
(this is the 'brightness-uncontrollable-exception')
(this is the 'cannot-be-added-to-system-exception')
Pretty gifs and pictures for clarity :)
Note how the light will just "turn off again" (no, I did not click it again ;) it turns off by itself)
Here you can see the one light that actually gives on/off and color control, but the brightness control does not work.
this is the debug logging that rolled out of that, note how it seems to constantly call "turn_on" even if the light is already on (this would happen if we'd move the brightness slider):
Personally I suspect Fibaro has changed something in their REST API which is causing these problems (since an older version of the same device does not have these issues), but I'm just not well versed enough in the home assistant code nor python to fix this myself :(
Could anyone help with this problem? (if anything is missing from the issue, please let me know so I can add it)
What is version of Home Assistant Core has the issue?
core-2021.8.8
What was the last working version of Home Assistant Core?
No response
What type of installation are you running?
Home Assistant OS
Integration causing the issue
Fibaro
Link to integration documentation on our website
https://www.home-assistant.io/integrations/fibaro/
Example YAML snippet
No response
Anything in the logs that might be useful for us?
Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 451, in async_update_ha_state self._async_write_ha_state() File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 500, in _async_write_ha_state attr.update(self.state_attributes or {}) File "/usr/src/homeassistant/homeassistant/components/light/__init__.py", line 857, in state_attributes data[ATTR_BRIGHTNESS] = self.brightness File "/usr/src/homeassistant/homeassistant/components/fibaro/light.py", line 82, in brightness return scaleto255(self._brightness) File "/usr/src/homeassistant/homeassistant/components/fibaro/light.py", line 25, in scaleto255 if value > 98: TypeError: '>' not supported between instances of 'NoneType' and 'int' Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 382, in async_add_entities await asyncio.gather(*tasks) File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 587, in _async_add_entity await entity.add_to_platform_finish() File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 711, in add_to_platform_finish self.async_write_ha_state() File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 464, in async_write_ha_state self._async_write_ha_state() File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 500, in _async_write_ha_state attr.update(self.state_attributes or {}) File "/usr/src/homeassistant/homeassistant/components/light/__init__.py", line 857, in state_attributes data[ATTR_BRIGHTNESS] = self.brightness File "/usr/src/homeassistant/homeassistant/components/fibaro/light.py", line 82, in brightness return scaleto255(self._brightness) File "/usr/src/homeassistant/homeassistant/components/fibaro/light.py", line 25, in scaleto255 if value > 98: TypeError: '>' not supported between instances of 'NoneType' and 'int'Additional information
No response
The text was updated successfully, but these errors were encountered: