Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kodi: inconsistency in configuration requirements #5692

Closed
Molodax opened this issue Feb 1, 2017 · 2 comments · Fixed by #6497
Closed

Kodi: inconsistency in configuration requirements #5692

Molodax opened this issue Feb 1, 2017 · 2 comments · Fixed by #6497

Comments

@Molodax
Copy link

Molodax commented Feb 1, 2017

Make sure you are running the latest version of Home Assistant before reporting an issue.

You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:

Home Assistant release (hass --version):
36.1, 37.0

Python release (python3 --version):
any

Component/platform:
Kodi

Description of problem:
Kodi media player does not require httpfor host name anymore (introduced in #5098), however, Kodi notification component still requires it. This is confusing that the same platform requires different format of the same host.

Expected:
Consistency in the requirements within, at least, the same platform.

Problem-relevant configuration.yaml entries and steps to reproduce:

# Example configuration.yaml entry
notify:
  - platform: kodi
    name: NOTIFIER_NAME
    host: http://192.168.0.123

media_player:
  - platform: kodi
    host: 192.168.0.123

Traceback (if applicable):

Additional info:

@tbrasser
Copy link

tbrasser commented Feb 8, 2017

Maybe it's a good effort to make the host key consistent across all components? Are there any guidelines in the developer documentation that favour one over the other? Thanks for the issue, this threw me of as well, I had issues connecting to Kodi and was looking for inconsistencies in my configuration, thought I fixed it but made it worse instead.

Edit:
Lol, https://home-assistant.io/developers/component_initialization/ does actually give an example without http://, but it's not really a guideline. :P

@emlove
Copy link
Contributor

emlove commented Mar 9, 2017

Thanks for bringing this up! When I did the Kodi conversion I didn't realize there was an extra Kodi platform floating out there.

We don't have any actual guideline for host, but Kodi was one of the few if maybe the only platform to use the format. I believe it was an artifact of being one of the very early Home Assistant platforms. The problems with the format came to light when we wanted to add websocket support.

@home-assistant home-assistant locked and limited conversation to collaborators Jul 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants