Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SamsungTV integration translation error #59249

Closed
landaisbenj opened this issue Nov 6, 2021 · 4 comments
Closed

SamsungTV integration translation error #59249

landaisbenj opened this issue Nov 6, 2021 · 4 comments

Comments

@landaisbenj
Copy link
Contributor

The problem

When SamsungTV integration is discovered, frontend can't display the model variable in translation:

Translation Error: The intl string context variable "model" was not provided to the string "Samsung TV: {model}"

image

What version of Home Assistant Core has the issue?

core-2021.11.0

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Supervised

Integration causing the issue

samsungtv

Link to integration documentation on our website

https://www.home-assistant.io/integrations/samsungtv/

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

@probot-home-assistant
Copy link

samsungtv documentation
samsungtv source
(message by IssueLinks)

@probot-home-assistant
Copy link

Hey there @escoand, @chemelli74, mind taking a look at this issue as it has been labeled with an integration (samsungtv) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@milanmeu
Copy link
Contributor

milanmeu commented Nov 7, 2021

Hi @landaisbenj,
The string changed but some translations didn't. I fixed them in Lokalise. The change will be in the next major release.
Thanks for reporting this issue.

@landaisbenj
Copy link
Contributor Author

Thanks for your work !!!

@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants