Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TimeSMAFilter based on time #62941

Closed
hk-ret opened this issue Dec 28, 2021 · 6 comments
Closed

Update TimeSMAFilter based on time #62941

hk-ret opened this issue Dec 28, 2021 · 6 comments

Comments

@hk-ret
Copy link

hk-ret commented Dec 28, 2021

The problem

@Danielhiversen @dgomes
Some time ago I've created an issue #57337 and was advised that it will be addressed in #53053. Now I've noticed that this issue has been closed without being fixed. Is there any chance, that a fix will be implemented?

What version of Home Assistant Core has the issue?

core-2021.9.7

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Core

Integration causing the issue

Filter Sensor

Link to integration documentation on our website

https://www.home-assistant.io/integrations/filter/#time-simple-moving-average

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

@probot-home-assistant
Copy link

Hey there @dgomes, mind taking a look at this issue as it has been labeled with an integration (filter) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)


filter documentation
filter source
(message by IssueLinks)

@github-actions github-actions bot added the stale label Jan 27, 2022
@Kimble8650
Copy link

Kimble8650 commented Feb 3, 2022

This is very much an issue for me as well... A moving average based only on ever changing states is not sustainable. (I am averaging wind direction, and if the wind starts blowing constantly from one direction, the average will be off from the actual direction).
EDIT: Tagging also @Danielhiversen, as he made the pull request, that got stale. Was there some unforeseen issue that arose, or did you just lose momentum? =)
Maybe we can help in solving the issue? I've yet to dip my toes into the ocean of HA development, but I have read quite a lot of the HA source code in trying to figure out how stuff works. I think your pull request was on track to do some good things!

@github-actions github-actions bot removed the stale label Feb 3, 2022
@Danielhiversen
Copy link
Member

I have not found time to finish it yet.
So any help is much appreciated.

@github-actions
Copy link

github-actions bot commented May 4, 2022

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 4, 2022
@Kimble8650
Copy link

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

Yeah, the update has not fixed this.

@github-actions github-actions bot removed the stale label May 19, 2022
@github-actions
Copy link

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 25, 2022
@github-actions github-actions bot closed this as completed Sep 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants