Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary sensor for ISS not returning any information (follow-up to #60647) #63976

Closed
newtrim opened this issue Jan 12, 2022 · 8 comments
Closed

Comments

@newtrim
Copy link

newtrim commented Jan 12, 2022

The problem

See issue #60647 which was closed by the gitbot before being addressed.

to repeat ... this Integration is broken... and has been for some time.

HA version 2021.6.6 has a working binary sensor for NASA International Space Station (ISS) info . Using all subsequent HA versions, NO information is now returned from the interface as it is unable to initialise judging by the error log entry.

The interface is still working on version 2021.6.6 so I assume the NASA end is still functioning ok.

What version of Home Assistant Core has the issue?

all versions onwards from last working version

What was the last working version of Home Assistant Core?

core-2021.6.6

What type of installation are you running?

Home Assistant Container

Integration causing the issue

NASA ISS

Link to integration documentation on our website

https://www.home-assistant.io/integrations/iss/

Example YAML snippet

the standard definition from the documentation

# NASA - ISS above horizon by 10 degrees in your location
binary_sensor:
  - platform: iss
    show_on_map: false

Anything in the logs that might be useful for us?

Logger: homeassistant.components.binary_sensor
Source: components/iss/binary_sensor.py:96 
Integration: Binary Sensor (documentation, issues) 
First occurred: 28 November 2021, 20:23:10 (2 occurrences) 
Last logged: 28 November 2021, 20:23:10

Error adding entities for domain binary_sensor with platform iss
Error while setting up iss platform for binary_sensor
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 382, in async_add_entities
    await asyncio.gather(*tasks)
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 607, in _async_add_entity
    await entity.add_to_platform_finish()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 715, in add_to_platform_finish
    self.async_write_ha_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 486, in async_write_ha_state
    self._async_write_ha_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 522, in _async_write_ha_state
    extra_state_attributes = self.extra_state_attributes
  File "/usr/src/homeassistant/homeassistant/components/iss/binary_sensor.py", line 96, in extra_state_attributes
    attrs["long"] = self.iss_data.position.get("longitude")
AttributeError: 'NoneType' object has no attribute 'get'

Additional information

No response

@probot-home-assistant
Copy link

iss documentation
iss source
(message by IssueLinks)

@newtrim
Copy link
Author

newtrim commented Jan 12, 2022

Please take a look at this as it's a straight forward integration that now does not connect to the designated NASA API properly (or at least that's how I read the error log).

@newtrim
Copy link
Author

newtrim commented Jan 17, 2022

I'd like to take advantage of recent HA developments, but while this item is broken I am unable to upgrade. As it's been outstanding for 6 months I think it should be fixed as a priority over development please. Thanks

@VDRainer
Copy link
Contributor

No problems here with ISS binary_sensor.

binary_sensor:
  - platform: iss
    #show_on_map: True

20220117_224013
I see the backtrace you posted from time to time, but most of the time it works.

@spacegaier spacegaier changed the title BROKEN - Binary sensor for ISS not returning any information -> was issue #60647 Binary sensor for ISS not returning any information (follow-up to #60647) Jan 18, 2022
@spacegaier
Copy link
Member

Works fine for me as well. The above posted exception can only occur if for some reason the NASA service did not provide position information back.

@newtrim
Copy link
Author

newtrim commented Jan 24, 2022

Is this a docker container version issue?

I've set up a workaround using a second container running 2021.6.6 for ISS data and connecting to main container using MQTT.

@github-actions
Copy link

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 24, 2022
@newtrim
Copy link
Author

newtrim commented Apr 25, 2022

The newly written Integration allows this to now work, however I do not want to upgrade to it because of other issues, so I am keeping my workaround.
Closing the issue as no one was assigned, and a work around or solution now available.

@newtrim newtrim closed this as completed Apr 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants