Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miiocli fails to run starting with 2022.5.0 #71495

Closed
unclehack opened this issue May 7, 2022 · 7 comments · Fixed by #75415
Closed

miiocli fails to run starting with 2022.5.0 #71495

unclehack opened this issue May 7, 2022 · 7 comments · Fixed by #75415
Assignees
Labels
integration: xiaomi_miio waiting-for-upstream We're waiting for a change upstream

Comments

@unclehack
Copy link

unclehack commented May 7, 2022

The problem

The miiocli is part of the python-miio package. This is useful for using devices with older firmware which expose more features than the current integrations provide.

 miiocli
Traceback (most recent call last):
  File "/usr/local/bin/miiocli", line 5, in <module>
    from miio.cli import create_cli
  File "/usr/local/lib/python3.9/site-packages/miio/cli.py", line 43, in <module>
    cli.add_command(device_class.get_device_group())
  File "/usr/local/lib/python3.9/site-packages/miio/integrations/vacuum/roborock/vacuum.py", line 932, in get_device_group
    @dg.resultcallback()

This is broken inside the HA container.

miiocli --help
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
NameError: name 'miiocli' is not defined

This cli utility worked in previous versions before 2022.5.0. I'll have to replace HA with something else if this can't be fixed.

There's a known bug in python-miio 0.5.11. This bug wasn't triggered in 2022.4.7. miiocli commands run without errors on my Linux machine with Python 3.9.7.

What version of Home Assistant Core has the issue?

2022.5.0

What was the last working version of Home Assistant Core?

2022.4.7

What type of installation are you running?

Home Assistant OS

Integration causing the issue

miio

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

@probot-home-assistant
Copy link

xiaomi_miio documentation
xiaomi_miio source
(message by IssueLinks)

@probot-home-assistant
Copy link

Hey there @rytilahti, @syssi, @starkillerOG, @bieniu, mind taking a look at this issue as it has been labeled with an integration (xiaomi_miio) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@rytilahti
Copy link
Member

This will require a new python-miio release and a version bump. Upstream issue can be found here rytilahti/python-miio#1389 and as a temporary solution you can either apply the oneline patch to your installation or downgrade click to 7-series (if possible).

@probot-home-assistant
Copy link

xiaomi_miio documentation
xiaomi_miio source
(message by IssueLinks)

@probot-home-assistant
Copy link

Hey there @starkillerOG, mind taking a look at this issue as it has been labeled with an integration (xiaomi_miio) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@arkadiusz-kopicinski
Copy link

Any news regarding this issue? Can You estimate when will be updated? Thanks!

@rytilahti
Copy link
Member

@arkadiusz-kopicinski you can follow rytilahti/python-miio#1436 to see when the upstream release gets done, then it just about version bump on homeassistant's end.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
integration: xiaomi_miio waiting-for-upstream We're waiting for a change upstream
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants