Hydrawise automatic_watering switch unsuspend not working - Fix available

[timvdsm]

The problem

Hi!
Now the automatic_watering switch suspends watering for one year (not configurabe) and when toggled, the code sending the suspend to 0 period by the switch.py below:
self.hass.data[DATA_HYDRAWISE].data.suspend_zone(0, relay_data)

In the Hydrawise log appears the following:
Suspending scheduled watering for Hydrawise Zone1 Frontyard till Thursday, 1st of January 1970, 01:00AM

But the zone still suspended for the previously set one year on the Hydrawise webpage (must cancel manually) and the switch status in HA also still representing this suspended state. This causing the zones cannot be unsuspended by the integration.

Unsuspend does not work right now, because the v1.4 API does not like the period_id=999 when issuing an unsuspend.
@prwood80 & @sipossz have tested this change locally, and the fix works just fine.
ptcryan/hydrawiser#11

So for my understanding this just needs to be merged. Can this be done pls?

What version of Home Assistant Core has the issue?

Core 2022.6.6

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

hydrawise

Link to integration documentation on our website

https://www.home-assistant.io/integrations/hydrawise/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

Hydrawise api can be find here:
https://support.hydrawise.com/hc/en-us/articles/360008965753-Hydrawise-API-Information

[probot-home-assistant]

hydrawise documentation
hydrawise source
_{^{(message by IssueLinks)}}

[probot-home-assistant]

Hey there @ptcryan, mind taking a look at this issue as it has been labeled with an integration (hydrawise) you are listed as a code owner for? Thanks!
_{^{(message by CodeOwnersMention)}}

[github-actions]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

[sipossz]

The bug had fixed and tested, but haven't merged by the code owner @ptcryan

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

[sipossz]

@MartinHjelmare, please also merge this Hydrawise stale issue fix to production! It had fixed, but not merged, because the code owner haven't available since than. Thanks, Szabi

[MartinHjelmare]

Sorry, I don't understand what you are asking of me to do. I don't see any Home Assistant Core PR referenced here, only a library PR.

[issue-triage-workflows]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.