Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GroWatt - AC Couple Inverter Type Failing #77232

Closed
JasSmiths opened this issue Aug 23, 2022 · 13 comments
Closed

GroWatt - AC Couple Inverter Type Failing #77232

JasSmiths opened this issue Aug 23, 2022 · 13 comments

Comments

@JasSmiths
Copy link

The problem

Adding a Growatt Storage Inverter type of 'AC Couple' doesn't appear to be working, everything shows as unavailable however it does pick up the Plant Name so some communication is happening.

Note: This isnt the current issue where the server URL needs changing, my other inverters are showing correctly its just the 'AC Couple' that is having issues.

What version of Home Assistant Core has the issue?

core-2022.8.6

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Growatt

Link to integration documentation on our website

https://www.home-assistant.io/integrations/growatt_server/

Diagnostics information

Not available with this integration

Example YAML snippet

No response

Anything in the logs that might be useful for us?

Logger: homeassistant.components.growatt_server.sensor
Source: components/growatt_server/sensor.py:164 
Integration: Growatt (documentation, issues) 
First occurred: 12:46:00 pm (126 occurrences) 
Last logged: 9:47:04 pm

Unable to fetch data from Growatt server

Additional information

@muppet3000 - Happy to work with you to add this if it hasn't already been added into the integration.

@probot-home-assistant
Copy link

growatt_server documentation
growatt_server source
(message by IssueLinks)

@probot-home-assistant
Copy link

Hey there @indykoning, @muppet3000, @JasperPlant, mind taking a look at this issue as it has been labeled with an integration (growatt_server) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@JasSmiths
Copy link
Author

@muppet3000 Would you mind taking a look into this please? Doesn't seem to have been picked up on

@muppet3000
Copy link
Contributor

Hi All,
I have seen this and I'm working hard to find some actual time to work on HA again over the winter. I've had a lot of other stuff keeping me busy over the summer, but now the nights are getting darker and the weather is getting colder I'll be spending more of my evening's indoors and will pick up this (as well as a load of other) Growatt items.

@muppet3000
Copy link
Contributor

Hi All,

This is a massive cross-post on all the Growatt tickets so apologies for it's generic format. I've collated all of the open issues and prioritised them here: https://community.home-assistant.io/t/growatt-integration-prioritised-list-of-features-for-implementation-fixing/483850

I will be working through them in order and updating that post as well as the affected tickets. Using that method I can be sure to correctly track everything associated with the integration.

Watch this space!

@JasSmiths
Copy link
Author

@muppet3000 Absolute hero, thank you!

@muppet3000

This comment was marked as off-topic.

@frenck
Copy link
Member

frenck commented Jan 12, 2023

I've hidden your comment @muppet3000. The Home Assistant project does not recommend or support the use of custom integrations.

../Frenck

@muppet3000
Copy link
Contributor

A great suggestion has been made on the above (see hidden comment) forum link to continue support of the Core integration by taking a monthly roll-up of the changes in the HACS version of the integration and submitting them via the formal review process into Core. This will ensure that the integration continues to meet the standards expected of a Core integration.

Therefore, those of you that wish to continue using just the Core version of the integration will still be able to it will just receive updates/fixes at a slightly slower rate.

I will continue to monitor & respond to bugs and issues raised in Core but they will be first fixed externally before making it into a Core PR.

I hope this provides the best of both worlds for everyone involved.

@frenck
Copy link
Member

frenck commented Jan 13, 2023

Please note that that model does have downsides; for example, we will be changing the core version to keep up with core changes and will not contribute those fixes and changes to custom integrations.

Additionally, custom integrations have to take into account multiple versions of Home Assistant in the same codebase (e.g., take care of compatibility differences), while core integrations do not need such logic.

The code base, therefore, will there diverge and not be the same. Your statement is therefore, something that generally can't be achieved.

@muppet3000 Will you please stop crossposting the same message on all issues related to growatt_server? Consider that a warning, please. That is not wished for.

../Frenck

@issue-triage-workflows
Copy link

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

@muppet3000
Copy link
Contributor

Issue will not be fixed in this integration by me, I'm phasing out this integration due to lack of official API support from Growatt.
As soon as I've finished producing an alternative integration I'll look to formally remove this from Core as it causes confusion for people when it doesn't work.

@muppet3000
Copy link
Contributor

@home-assistant close

@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants