Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023.3.2 breaks backups via supervisor API #90400

Closed
cserem opened this issue Mar 28, 2023 · 11 comments
Closed

2023.3.2 breaks backups via supervisor API #90400

cserem opened this issue Mar 28, 2023 · 11 comments

Comments

@cserem
Copy link

cserem commented Mar 28, 2023

The problem

Before 2023.3.2 i was able to create and download backups remotely with simple http calls with a Bearer token. This somehow changed 2023.3.2. Now I am getting 401 error for these calls.

What version of Home Assistant Core has the issue?

2023.3.2

What was the last working version of Home Assistant Core?

2023.3.1

What type of installation are you running?

Home Assistant OS

Integration causing the issue

No response

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

@andriej
Copy link
Contributor

andriej commented Mar 29, 2023

It's probably due to tightening of security in PR: #89379

@BradleyGeldenhuys
Copy link

Seems due to the CVE the fix was to disable access to the Supervisor all together. This has left our backup and monitoring system offline. Could it not be possible to fix the authentication issue and allow access to the API again in a more secure manner?

@cserem
Copy link
Author

cserem commented Mar 29, 2023

@andriej yes, most probably it is related to that commit, however i wasn't able to figure out if this denied access altogether, or if it can be tweaked to be working again (the supervisor API documentation didn't seem to have changed)

@BradleyGeldenhuys the CVE fix came with 2023.3.0: https://www.home-assistant.io/blog/2023/03/08/supervisor-security-disclosure/

@BradleyGeldenhuys
Copy link

Correct, but still an issue since then.

@cserem
Copy link
Author

cserem commented Mar 29, 2023

Correct, but still an issue since then.

Could you downgrade to 2023.3.1. ? (edited the version number)
For me it worked (backup creation and download)

@BradleyGeldenhuys
Copy link

I will let you know.

@BradleyGeldenhuys
Copy link

Tested 2023.3.1 and backups are still working. Updated to 2023.3.2 and get 401Unauthorized

@cserem
Copy link
Author

cserem commented Apr 3, 2023

I belive #89379 is what causing the headaches.
I wonder if we can summon @frenck like this to investigate?

@BradleyGeldenhuys
Copy link

Still an issue with the latest release
Home Assistant 2023.4.5
Supervisor 2023.04.0
Operating System 10.0
Frontend 20230411.1 - latest

@ludeeus
Copy link
Member

ludeeus commented Apr 19, 2023

Duplicate of #89919

@ludeeus ludeeus marked this as a duplicate of #89919 Apr 19, 2023
@ludeeus ludeeus closed this as not planned Won't fix, can't repro, duplicate, stale Apr 19, 2023
@cserem
Copy link
Author

cserem commented Apr 19, 2023

I guess we are out of luck with this.

I have found this thread: https://community.home-assistant.io/t/supervisor-external-api-access/428649/2
which mentiones this addon: https://github.com/home-assistant/addons-development/tree/master/remote_api

I haven't had the time to try it out yet, but I am leaving it here for refernce.

@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants