Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Assistant Entities Many Unintended Entities Exposed via Nabu Casa #92099

Closed
Anto79-ops opened this issue Apr 27, 2023 · 7 comments
Closed
Assignees
Milestone

Comments

@Anto79-ops
Copy link

Anto79-ops commented Apr 27, 2023

The problem

Hi,

Since updating to 2023.5b0, I noticed that the total entities exposed to Google Assistant(GA) via Nabu Casa seems to be incorrect. For example, the new GUI for entities exposure says I have 1893 entities exposed to Google Assistant:

image

Before beta, I maybe had ~60 entities exposed to GA.

Its not clear if the entities are actually exposed to GA as I don't even see them in the Google Home app even after "resyncing all devices" on GA.

Clicking on 1 of the entites that is listed shows that it is exposed to GA:

image

So, either the problem is that it is exposing all possible entities and ignored my previously unexposed entities OR it has not exposed the entities to GA that it claims?

Pre-beta, I used the GUI in Home Assistant Cloud and managed the entities simply by selecting the entity and exposing it by clicking on the green square/check or red square/check if I did not want it exposed. For example, this photo shows pre-beta

image

What version of Home Assistant Core has the issue?

2023.5.0b0

What was the last working version of Home Assistant Core?

2023.4.6

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Nabu Casa

Link to integration documentation on our website

https://www.nabucasa.com/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

@balloob balloob added this to the 2023.5.0 milestone Apr 27, 2023
@emontnemery
Copy link
Contributor

@Anto79-ops Please share these files from .storage:

  • cloud:
    • The full file is not needed, it's enough to share these keys:
      • google_default_expose
      • google_entity_configs
  • core.entity_registry

@emontnemery
Copy link
Contributor

I think this will be fixed by #92105, it would still be good to see the google_default_expose settings + entity registry though to confirm

@Anto79-ops
Copy link
Author

Anto79-ops commented Apr 27, 2023

thanks, I just sent you a private message in Discord containing the 2 files

@Mariusthvdb
Copy link
Contributor

Mariusthvdb commented Apr 28, 2023

seeing something related I suppose, though not sure it has only to do with the unsupported entities of #92105.

yesterday I had 0 entities exposed in the Assistant UI suddenly (was it after updating to b1?) I notice 870 exposed entities:

Scherm­afbeelding 2023-04-28 om 13 14 49

since I have my google assistant in yaml configured historically, I checked that (in the new but less comfortable and now very unintuitive interface imho), and note the number:

Scherm­afbeelding 2023-04-28 om 13 12 51

not sure why this means, but hope it helps in analyzing the issue here. I certainly dont want any of these entities to be exposed without explicit consent. Which I didnt to my knowledge....

@Anto79-ops
Copy link
Author

Anto79-ops commented Apr 28, 2023

Yes, you'll have to manually unexpose the entities because the migration already happened in b0.

This issue should be closed because the problem was fixed in b1 @emontnemery @balloob

EDIT: wait, it sounds like you are saying that the issue happened from b0 to b1.... Ok, could be an issue then. I know after I manually unexposed the entities in b0, it remained the same in b1.

@Mariusthvdb
Copy link
Contributor

Mariusthvdb commented Apr 28, 2023

yes, happened after updating from b0 to b1

what would also be a very useful option, is when we could simply select and copy those entities over from 1 provider (assistant) to another...

manually selecting all of those entities is a real pain, and very user-unfriendly.
though I guess the default response now will be that is a FR...

@Anto79-ops
Copy link
Author

Anto79-ops commented May 3, 2023

Hi, when I updated to b6 b7 it looks like it exposed more entities as shown here:

image

However, when I click on the "3819 entities exposed" button and it shows me the list of exposed entities, it only shows me the 84 entities that I originally has exposed.

I will DM you the core.entity_registry and cloud files.

Assist entities remained unchanged during this upgrade to b6 b7.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants