Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pydaikin 2.9.1 #93635

Merged
merged 3 commits into from May 29, 2023
Merged

Bump pydaikin 2.9.1 #93635

merged 3 commits into from May 29, 2023

Conversation

mover85
Copy link
Contributor

@mover85 mover85 commented May 27, 2023

Proposed change

Bump Daikin version, changelog: https://bitbucket.org/mustang51/pydaikin/branches/compare/v2.9.1%0Dv2.9.0

Add zone temperature control.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hi @mover85

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Hey there @fredrike, mind taking a look at this pull request as it has been labeled with an integration (daikin) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of daikin can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign daikin Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@fredrike
Copy link
Contributor

fredrike commented May 27, 2023

@mover85 it would be great if there were a service call to set the other zones too..
https://developers.home-assistant.io/docs/dev_101_services/

And, add yourself as code owner.

@fredrike
Copy link
Contributor

fredrike commented May 27, 2023

Closes #87994, #84923

Copy link
Contributor

@fredrike fredrike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@mover85
Copy link
Contributor Author

mover85 commented May 27, 2023

@mover85 it would be great if there were a service call to set the other zones too.. https://developers.home-assistant.io/docs/dev_101_services/

And, add yourself as code owner.

@fredrike I'll add a service call when I update the integration in the coming days. I will add myself as code owner too!

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mover85 👍

Great first-time contribution! Feel free to add more of them 🥇

../Frenck

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label May 29, 2023
@frenck frenck merged commit 07dd34b into home-assistant:dev May 29, 2023
51 of 52 checks passed
@mover85 mover85 deleted the bump-pydaikin branch May 29, 2023 23:20
@fredrike
Copy link
Contributor

fixes #87994, #84923

@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed code-owner-approved dependency integration: daikin Quality Scale: platinum small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Temp sensors not updating and different to value shown on climate entity
3 participants