Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After clicking on Generic Camera integration image, image too small #96352

Closed
mkanet opened this issue Jul 11, 2023 · 6 comments
Closed

After clicking on Generic Camera integration image, image too small #96352

mkanet opened this issue Jul 11, 2023 · 6 comments
Assignees

Comments

@mkanet
Copy link

mkanet commented Jul 11, 2023

The problem

When I used to click on a "generic camera" integration image on my Home Assistant webpage, the original native image size (1920x1080p) would be displayed ...taking up most of the web browser's screen (which is exactly what I want; and, very useful).

However, something changed in Home Assistant (about 5-6 months) that when I click on the image, it now displays a very small (scaled down) image; requiring me to manually zoom the entire web browser's webpage every time to see all the small text and other details in the image. When I asked on the forums about this issue, other users also confirmed they also have the same problem.

I already checked the documentation: https://www.home-assistant.io/integrations/generic/ to see if there is a new setting to control default image size (when clicked); however, I didn't find any settings for this. I am guessing this is most likely a bug that was accidentally introduced a little while back?

Anyway, is there a way I revert "generic camera" integration back to original behavior? It isn't very useful currently.

See below screenshot, generic camera image is too small after I click it. Its native image resolution is 1920x1080; which should take most of the web browser screen area after it is clicked.
Broken

What version of Home Assistant Core has the issue?

core-2023.6.3

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Supervised

Integration causing the issue

Generic Camera

Link to integration documentation on our website

https://www.home-assistant.io/integrations/generic/

Diagnostics information

Please let me know if there's a specific log you would like for me to share.

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

@home-assistant
Copy link

Hey there @davet2001, mind taking a look at this issue as it has been labeled with an integration (generic) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of generic can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign generic Removes the current integration label and assignees on the issue, add the integration domain after the command.

(message by CodeOwnersMention)


generic documentation
generic source
(message by IssueLinks)

@davet2001
Copy link
Contributor

Confirmed and can reproduce this.

Repro steps:

Expected result
Image is big or has a maximise button

Actual result
Image is small

@mkanet
Copy link
Author

mkanet commented Jul 23, 2023

@davet2001 or anyone, is this something that can be fixed in the next update?

Until then, could you please suggest a temporary solution to display the native image size when it's clicked? I can download the folder below:

https://github.com/home-assistant/core/tree/dev/homeassistant/components/generic

...and make a change to one of the source files and place the folder under:

\config\custom_components

@davet2001
Copy link
Contributor

I did a bit of playing around with this, and found that I can get the image to maximise in my browser by clicking the text of the title on the pop-up.

Does that work in your case? If it does, it's a temporary solution, but probably needs a tweak to the UI to make it more obvious

@mkanet
Copy link
Author

mkanet commented Jul 25, 2023

I did a bit of playing around with this, and found that I can get the image to maximise in my browser by clicking the text of the title on the pop-up.

Does that work in your case? If it does, it's a temporary solution, but probably needs a tweak to the UI to make it more obvious

Thank you so much for the tip. It does work for me. Yes, a tweak to the UI to make it more obvious would be great.

@davet2001
Copy link
Contributor

davet2001 commented Jul 25, 2023

Please see home-assistant/frontend#17406

@davet2001 davet2001 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants