Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rainbird integration failed to setup #96608

Closed
bcjmk opened this issue Jul 15, 2023 · 2 comments · Fixed by #96610
Closed

Rainbird integration failed to setup #96608

bcjmk opened this issue Jul 15, 2023 · 2 comments · Fixed by #96610
Assignees
Milestone

Comments

@bcjmk
Copy link

bcjmk commented Jul 15, 2023

The problem

Home Assistant 2023.7.2
Supervisor 2023.07.1
Operating System 10.3
Frontend 20230705.1 - latest

Trying to setup Rainbird integration with ARC8 controller. Connects and authenticates but fails to discover and create devices or entities.
I believe this is a relatively new model, so possibly just need the code updated

What version of Home Assistant Core has the issue?

core-2023.7.2

What was the last working version of Home Assistant Core?

Not working

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Rainbird

Link to integration documentation on our website

https://www.home-assistant.io/integrations/rainbird/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

2023-07-15 13:01:49.654 DEBUG (MainThread) [pyrainbird.async_client] Request (ModelAndVersionRequest): 02
2023-07-15 13:01:49.655 DEBUG (MainThread) [pyrainbird.async_client] Request: {"id": 1689440509.6552691, "jsonrpc": "2.0", "method": "tunnelSip", "params": {"data": "02", "length": 1}}
2023-07-15 13:01:49.983 DEBUG (MainThread) [pyrainbird.async_client] Response: {"id":1689440509.6552691,"jsonrpc":"2.0","result":{"data":"820813020C","length":5}}
2023-07-15 13:01:49.984 DEBUG (MainThread) [pyrainbird.async_client] Response from line: 820813020C
2023-07-15 13:01:49.984 DEBUG (MainThread) [pyrainbird.async_client] Response: {'type': 'ModelAndVersionResponse', 'modelID': 2067, 'protocolRevisionMajor': 2, 'protocolRevisionMinor': 12}
2023-07-15 13:01:49.984 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry <HOSTNAME> for rainbird
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 390, in async_setup
    result = await component.async_setup_entry(hass, self)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/rainbird/__init__.py", line 35, in async_setup_entry
    model_info = await controller.get_model_and_version()
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pyrainbird/async_client.py", line 174, in get_model_and_version
    if self._model.model_info.retries:
       ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pyrainbird/data.py", line 100, in model_info
    return ModelInfo(**RAINBIRD_MODELS["%04x" % self.model])
                       ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^
KeyError: '0813'

Additional information

No response

@home-assistant
Copy link

Hey there @konikvranik, @allenporter, mind taking a look at this issue as it has been labeled with an integration (rainbird) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of rainbird can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign rainbird Removes the current integration label and assignees on the issue, add the integration domain after the command.

(message by CodeOwnersMention)


rainbird documentation
rainbird source
(message by IssueLinks)

@allenporter allenporter added this to the 2023.7.3 milestone Jul 15, 2023
@allenporter
Copy link
Contributor

Thank you for the report. This regression was introduced by the fix to #92857 that attempts to find the model number. Downgrading back to .1 should get you unstuck and i'll target a patch for .3

@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants