-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2023.8.3 fix for modbus broke my modbus config - can't load anymore #98692
Comments
Hey there @adamchengtkc, @janiversen, @vzahradnik, mind taking a look at this issue as it has been labeled with an integration ( Code owner commandsCode owners of
(message by CodeOwnersMention) modbus documentation |
modbus in .3 is broken, it is fixed on dev. You can do:
the fix will be in .4 |
Your config is wrong, "swap: word" on int16 do not make sense a word is 32 bit. version .3 catches this configuration error instead of producing wrong data. |
Thanks. But: swap string (optional, default: none) A configuration error should MAYBE popup as a repair or warning in HA. |
You are entitled to your opinion, but
And the documentation is correct. A word is defined to be 32bits, so what do you expect. our best option was to catch it at configuration time, and inform the user. If you do not agree, then pull requests are welcome. |
Don't get me wrong. What I do see a bit critical - is the way how it was done. Anyway - removing the swap: word from my config seems to have solved the issue. |
I performed a rollback, have used to many scripts with swap implemented as below. name: Reactive power
unique_id: sg_reactive_power
slave: !secret sungrow_modbus_slave
address: 5032 # reg 5033
input_type: input
count: 2
data_type: int32
swap: word
precision: 0
unit_of_measurement: W
device_class: power
state_class: measurement
scale: 1
scan_interval: 10 |
swap works in .3 the problem is slave:, this is already solved on dev, so closing issue. you do have a problem in your configuration, you cannot mix count: and datatype: apart from custom. |
Still broken in .4 |
Did you bother reading the error message ? you have an illegal configuration. Please read the documentation, instead of claiming there is a bug in the integration: https://www.home-assistant.io/integrations/modbus/#parameters-usage-matrix |
I changed all uint16 and int16 to 32 bit.
Still getting the same errors. |
Did you actually read the link I sent you...at least I can see that you did not check your parameters against the table. Changing everything to INT32, only works if you also change your device. If your device delivers INT16 it will continue to do so. |
The problem
``The Update of 2023.8.3 broke my modbus configuration which I've used to Connect to a Siemens LOGO.
The config was working until the Update, No issues where detected.
Now, the system can't load the configuration anymore.
What version of Home Assistant Core has the issue?
2023.8.3
What was the last working version of Home Assistant Core?
No response
What type of installation are you running?
Home Assistant OS
Integration causing the issue
Morbus
Link to integration documentation on our website
No response
Diagnostics information
No response
Example YAML snippet
No response
Anything in the logs that might be useful for us?
No response
Additional information
No response
The text was updated successfully, but these errors were encountered: