Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the HomeKit (de)humidifier min/max humidity handling #90854

Merged
merged 1 commit into from Apr 5, 2023

Conversation

stackia
Copy link
Contributor

@stackia stackia commented Apr 5, 2023

Breaking change

The PR changes how min/max supported target humidities are handled for the HomeKit (de)humidifier devices.

For a (de)humidifier device that has a min/max humidity other than 0/100:

Before: The number shown on HomeKit UI doesn't represent the actual relative humidity.

image

After: The number shown on HomeKit UI is just the real relative humidity, as expected. When the slider goes above/below the max/min humidity, we'll set it back to the allowed max/min humidity.

image

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Apr 5, 2023

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (homekit) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of homekit can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign homekit Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@stackia stackia marked this pull request as ready for review April 5, 2023 15:26
@stackia stackia requested a review from bdraco as a code owner April 5, 2023 15:26
@bdraco
Copy link
Member

bdraco commented Apr 5, 2023

Please update the tests as well

@stackia stackia force-pushed the homekit-humidifier-min-max branch from a3536ab to 7d8d719 Compare April 5, 2023 15:42
@stackia
Copy link
Contributor Author

stackia commented Apr 5, 2023

@bdraco sorry, i just fixed

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested.

Thanks @stackia

@bdraco bdraco merged commit 5c2af99 into home-assistant:dev Apr 5, 2023
23 checks passed
@stackia stackia deleted the homekit-humidifier-min-max branch April 5, 2023 16:36
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For Humidifier, target % in HomeKit differs from actual target %.
2 participants