Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ozone state attribute and ozone sensors from Accuweather #91492

Merged
merged 5 commits into from Apr 16, 2023
Merged

Remove ozone state attribute and ozone sensors from Accuweather #91492

merged 5 commits into from Apr 16, 2023

Conversation

bieniu
Copy link
Member

@bieniu bieniu commented Apr 16, 2023

Breaking change

The ozone sensors and the ozone state attribute of the weather entity showed incorrect values and are being removed. If you use these values in your automations, you need to update them.

Proposed change

Due to my misinterpretation of the Accuweather API documentation, the ozone values of the sensors and the weather entity attribute show incorrect values - these are numeric values describing air quality (air quality index), not the concentration of ozone in the air. For this reason, I completely remove the ozone sensors and the ozone weather entity attribute. In the next step, I will add an air quality sensor.

obraz

obraz

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bieniu 👍

../Frenck

@frenck frenck merged commit 9d68cdc into home-assistant:dev Apr 16, 2023
26 checks passed
@bieniu bieniu deleted the accuweather-ozone branch April 16, 2023 13:52
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants