Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated set_doorbell_message UniFi Protect service #91523

Merged
merged 5 commits into from Apr 17, 2023

Conversation

AngellusMortis
Copy link
Contributor

@AngellusMortis AngellusMortis commented Apr 17, 2023

Breaking change

The previous deprecated set_doorbell_message service has been removed. Use the text entity for UniFi Protect LCD screen instead.

Proposed change

Removes deprecated service (was slated to be removed in 2023.3.0)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @briis, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (unifiprotect) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of unifiprotect can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign unifiprotect Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@AngellusMortis AngellusMortis changed the title Removes deprecated UniFi Protect service Remove deprecated set_message UniFi Protect service Apr 17, 2023
@AngellusMortis AngellusMortis changed the title Remove deprecated set_message UniFi Protect service Remove deprecated set_doorbell_message UniFi Protect service Apr 17, 2023
@bdraco
Copy link
Member

bdraco commented Apr 17, 2023

Tested 👍

@bdraco
Copy link
Member

bdraco commented Apr 17, 2023

Thanks @AngellusMortis

@bdraco bdraco merged commit fdc80e1 into home-assistant:dev Apr 17, 2023
26 checks passed
@AngellusMortis AngellusMortis deleted the remove-deprecations branch April 17, 2023 03:31
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants